Skip to content

Commit eb93f72

Browse files
committed
Cover line width and Awaitility in contribution guidelines
1 parent 6379b47 commit eb93f72

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ mvn xml-format:xml-format
2828
The formatter does not enforce a maximum line length, but please try to keep it below 100 characters
2929
to keep files readable across all mediums (IDE, terminal, Github...).
3030

31+
### Other text files (markdown, etc)
32+
33+
Similarly, enforce a right margin of 100 characters in those files. Editors and IDEs generally have
34+
a way to configure this (for IDEA, install the "Wrap to column" plugin).
35+
3136
## Coding style -- production code
3237

3338
Do not use static imports. They make things harder to understand when you look at the code
@@ -213,6 +218,10 @@ Static imports are permitted in a couple of places:
213218
when(codecRegistry.codecFor(DataTypes.INT)).thenReturn(codec);
214219
verify(codec).decodePrimitive(any(ByteBuffer.class), eq(ProtocolVersion.DEFAULT));
215220
```
221+
* All Awaitility methods, e.g.:
222+
```java
223+
await().until(() -> somethingBecomesTrue());
224+
```
216225
217226
Test methods names use lower snake case, generally start with `should`, and clearly indicate the
218227
purpose of the test, for example: `should_fail_if_key_already_exists`. If you have trouble coming

0 commit comments

Comments
 (0)