checkpatch: check for whitespace before semicolon at EOL

Eric Nelson · torvalds · commit 9a4cad4e25b9 · 2012-05-31T17:49:27.000-07:00
Requires --strict option during invocation:
	~/linux$ scripts/checkpatch --strict foo.patch

This tests for a bad habits of mine like this:

	return 0 ;

Note that it does allow a special case of a bare semicolon
for empty loops:

	while (foo())
		;

Signed-off-by: Eric Nelson &lt;eric.nelson@boundarydevices.com&gt;
Cc: Andy Whitcroft &lt;apw@canonical.com&gt;
Cc: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -2448,6 +2448,13 @@ sub process {
 				     "space prohibited between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
+
+# check for whitespace before a non-naked semicolon
+		if ($line =~ /^\+.*\S\s+;/) {
+			CHK("SPACING",
+			    "space prohibited before semicolon\n" . $herecurr);
+		}
+
 # Check operator spacing.
 		if (!($line=~/\#\s*include/)) {
 			my $ops = qr{

Original file line number	Diff line number	Diff line change
`@@ -2448,6 +2448,13 @@ sub process {`
`2448`	`2448`	`"space prohibited between function name and open parenthesis '('\n" . $herecurr);`
`2449`	`2449`	`}`
`2450`	`2450`	`}`
	`2451`	`+`
	`2452`	`+# check for whitespace before a non-naked semicolon`
	`2453`	`+ if ($line =~ /^\+.*\S\s+;/) {`
	`2454`	`+ CHK("SPACING",`
	`2455`	`+ "space prohibited before semicolon\n" . $herecurr);`
	`2456`	`+ }`
	`2457`	`+`
`2451`	`2458`	`# Check operator spacing.`
`2452`	`2459`	`if (!($line=~/\#\s*include/)) {`
`2453`	`2460`	`my $ops = qr{`