Clean up a lot of pyflakes warnings (PyGithub#1153)

s-t-e-v-e-n-k · web-flow · commit b8dad9817e2f · 2019-07-02T18:06:09.000+10:00
Clean up unused imports or unused variables to mostly silence pyflakes.
We aren't quite yet in a place where we can run it via Travis, but baby
steps.
diff --git a/github/InstallationAuthorization.py b/github/InstallationAuthorization.py
@@ -25,8 +25,6 @@
 #                                                                              #
 ################################################################################
 
-import datetime
-
 import github.GithubObject
 import github.PaginatedList
 import github.NamedUser
diff --git a/github/Invitation.py b/github/Invitation.py
@@ -24,8 +24,6 @@
 #                                                                              #
 ################################################################################
 
-import urllib
-
 import github.GithubObject
 
 
diff --git a/github/IssueEvent.py b/github/IssueEvent.py
@@ -173,14 +173,6 @@ def rename(self):
         self._completeIfNotSet(self._rename)
         return self._rename.value
 
-    @property
-    def rename(self):
-        """
-        :type: dict
-        """
-        self._completeIfNotSet(self._rename)
-        return self._rename.value
-
     @property
     def dismissed_review(self):
         """
diff --git a/github/MainClass.py b/github/MainClass.py
@@ -50,7 +50,6 @@
 
 import datetime
 
-import urllib
 import pickle
 import time
 import sys
@@ -61,12 +60,10 @@
 from Requester import Requester
 import AuthenticatedUser
 import NamedUser
-import Organization
 import Gist
 import github.PaginatedList
 import Repository
 import Installation
-import Legacy
 import License
 import Topic
 import github.GithubObject
diff --git a/github/Organization.py b/github/Organization.py
@@ -42,7 +42,6 @@
 ################################################################################
 
 import datetime
-import json
 
 import github.GithubObject
 import github.PaginatedList
diff --git a/github/PaginatedList.py b/github/PaginatedList.py
@@ -42,8 +42,6 @@
 except ImportError:
     from urlparse import parse_qs
 
-import github.GithubObject
-
 
 class PaginatedListBase:
     def __init__(self):
diff --git a/github/Project.py b/github/Project.py
@@ -22,9 +22,6 @@
 #                                                                              #
 ################################################################################
 
-import datetime
-import json
-
 import github.GithubObject
 import github.ProjectColumn
 
diff --git a/github/ProjectCard.py b/github/ProjectCard.py
@@ -22,8 +22,6 @@
 #                                                                              #
 ################################################################################
 
-import json
-
 import github.GithubObject
 
 # NOTE: There is currently no way to get cards "in triage" for a project.
diff --git a/github/ProjectColumn.py b/github/ProjectColumn.py
@@ -22,8 +22,6 @@
 #                                                                              #
 ################################################################################
 
-import json
-
 import github.GithubObject
 import github.Project
 import github.ProjectCard
diff --git a/github/Rate.py b/github/Rate.py
@@ -28,7 +28,6 @@
 ################################################################################
 
 import github.GithubObject
-import datetime
 
 
 class Rate(github.GithubObject.NonCompletableGithubObject):
diff --git a/github/Requester.py b/github/Requester.py
@@ -325,7 +325,7 @@ def __structuredFromJson(self, data):
                 data = data.decode("utf-8")  # pragma no cover (Covered by Issue142.testDecodeJson with Python 3)
             try:
                 return json.loads(data)
-            except ValueError, e:
+            except ValueError:
                 return {'data': data}
 
     def requestJson(self, verb, url, parameters=None, headers=None, input=None, cnx=None):
diff --git a/scripts/fix_headers.py b/scripts/fix_headers.py
@@ -26,13 +26,11 @@
 #                                                                              #
 ################################################################################
 
-import fnmatch
 import os
 import subprocess
-import itertools
 
 
-eightySharps = "################################################################################"
+eightySharps = "#"*80
 
 
 def generateLicenseSection(filename):
diff --git a/tests/CommitStatus.py b/tests/CommitStatus.py
@@ -32,7 +32,6 @@
 
 import Framework
 
-import github
 import datetime
 
 
diff --git a/tests/ConditionalRequestUpdate.py b/tests/ConditionalRequestUpdate.py
@@ -28,7 +28,6 @@
 ################################################################################
 
 import Framework
-import github
 
 
 class ConditionalRequestUpdate(Framework.TestCase):
diff --git a/tests/ContentFile.py b/tests/ContentFile.py
@@ -32,9 +32,6 @@
 
 import Framework
 
-import github
-import datetime
-
 
 class ContentFile(Framework.TestCase):
     def setUp(self):
diff --git a/tests/GitRelease.py b/tests/GitRelease.py
@@ -38,7 +38,6 @@
 import zipfile
 import datetime
 import Framework
-from pprint import pprint
 
 
 class Release(Framework.TestCase):
diff --git a/tests/GitReleaseAsset.py b/tests/GitReleaseAsset.py
@@ -26,7 +26,6 @@
 
 import datetime
 import Framework
-from pprint import pprint
 
 
 class ReleaseAsset(Framework.TestCase):
diff --git a/tests/GithubIntegration.py b/tests/GithubIntegration.py
@@ -1,9 +1,9 @@
 import jwt
 import json
-import time
+import time # NOQA
 import sys
 import unittest
-import requests
+import requests # NOQA
 import datetime
 from github.GithubObject import GithubObject
 
diff --git a/tests/Issue139.py b/tests/Issue139.py
@@ -26,7 +26,6 @@
 ################################################################################
 
 import Framework
-import github
 
 
 class Issue139(Framework.TestCase):  # https://github.com/jacquev6/PyGithub/issues/139
diff --git a/tests/Issue140.py b/tests/Issue140.py
@@ -26,7 +26,6 @@
 ################################################################################
 
 import Framework
-import github
 
 
 class Issue140(Framework.TestCase):  # https://github.com/jacquev6/PyGithub/issues/140
diff --git a/tests/Issue174.py b/tests/Issue174.py
@@ -26,7 +26,6 @@
 ################################################################################
 
 import Framework
-import github
 
 
 class Issue174(Framework.TestCase):
diff --git a/tests/Issue214.py b/tests/Issue214.py
@@ -25,8 +25,6 @@
 #                                                                              #
 ################################################################################
 
-import github
-
 import Framework
 
 
diff --git a/tests/Issue216.py b/tests/Issue216.py
@@ -26,7 +26,6 @@
 ################################################################################
 
 import Framework
-import github
 
 
 # Replay data forged by capitalizing headers from PaginatedList.setUp.txt and PaginatedList.testIteration.txt
diff --git a/tests/Issue50.py b/tests/Issue50.py
@@ -27,8 +27,6 @@
 #                                                                              #
 ################################################################################
 
-import github
-
 import Framework
 
 
diff --git a/tests/Issue87.py b/tests/Issue87.py
@@ -27,8 +27,6 @@
 #                                                                              #
 ################################################################################
 
-import github
-
 import Framework
 
 
diff --git a/tests/Issue937.py b/tests/Issue937.py
@@ -23,7 +23,6 @@
 ################################################################################
 import Framework
 
-import github
 
 class Issue937(Framework.TestCase):
     def setUp(self):
@@ -35,4 +34,4 @@ def testCollaboratorsAffiliation(self):
         collaborators = self.repo.get_collaborators(affiliation='direct')
         self.assertListKeyEqual(collaborators, lambda u: u.login, ["hegde5"])
         with self.assertRaises(AssertionError):
-            self.repo.get_collaborators(affiliation='invalid_option')
+            self.repo.get_collaborators(affiliation='invalid_option')
diff --git a/tests/Issue945.py b/tests/Issue945.py
@@ -24,8 +24,6 @@
 
 import Framework
 
-import github
-
 
 class Issue945(Framework.TestCase):  # https://github.com/PyGithub/PyGithub/issues/945
     def setUp(self):
diff --git a/tests/NamedUser.py b/tests/NamedUser.py
@@ -33,7 +33,6 @@
 
 import Framework
 
-import github
 import datetime
 
 
diff --git a/tests/Notification.py b/tests/Notification.py
@@ -30,8 +30,6 @@
 
 import Framework
 
-import datetime
-
 
 class Notification(Framework.TestCase):
     def setUp(self):
diff --git a/tests/PaginatedList.py b/tests/PaginatedList.py
@@ -137,7 +137,7 @@ def testCustomPerPage(self):
     def testCustomPerPageWithNoUrlParams(self):
         import CommitComment  # Don't polute github.tests namespace, it would conflict with github.tests.CommitComment
         self.g.per_page = 100
-        paginated_list = PaginatedListImpl(
+        PaginatedListImpl(
             CommitComment.CommitComment,
             self.repo._requester,
             self.repo.url + "/comments",
diff --git a/tests/Repository.py b/tests/Repository.py
@@ -583,7 +583,7 @@ def testMergeWithNothingToDo(self):
 
     def testMergeWithConflict(self):
         with self.assertRaises(github.GithubException) as raisedexp:
-            commit = self.repo.merge("branchForBase", "branchForHead")
+            self.repo.merge("branchForBase", "branchForHead")
         self.assertEqual(raisedexp.exception.status, 409)
         self.assertEqual(raisedexp.exception.data, {"message": "Merge conflict"})
 
diff --git a/tests/RequiredPullRequestReviews.py b/tests/RequiredPullRequestReviews.py
@@ -24,8 +24,6 @@
 
 import Framework
 
-import github
-
 
 class RequiredPullRequestReviews(Framework.TestCase):
     def setUp(self):
diff --git a/tests/RequiredStatusChecks.py b/tests/RequiredStatusChecks.py
@@ -24,8 +24,6 @@
 
 import Framework
 
-import github
-
 
 class RequiredStatusChecks(Framework.TestCase):
     def setUp(self):
diff --git a/tests/Retry.py b/tests/Retry.py
@@ -75,10 +75,8 @@ def testReturnsRepoAfter1Retry(self):
         self.assertEquals(repository.full_name, REPO_NAME)
 
     def testRaisesRetryErrorAfterMaxRetries(self):
-        try:
-            response = self.g.get_repo('PyGithub/PyGithub')
-            self.fail("RetryError should have been raised")
-        except requests.exceptions.RetryError:
-            self.assertEquals(len(httpretty.latest_requests), 4)
-            for request in httpretty.latest_requests:
-                self.assertEquals(request.path, '/repos/PyGithub/PyGithub')
+        with self.assertRaises(requests.exceptions.RetryError):
+            self.g.get_repo('PyGithub/PyGithub')
+        self.assertEquals(len(httpretty.latest_requests), 4)
+        for request in httpretty.latest_requests:
+            self.assertEquals(request.path, '/repos/PyGithub/PyGithub')
diff --git a/tests/Time.py b/tests/Time.py
@@ -20,7 +20,7 @@
 #                                                                              #
 ################################################################################
 
-from datetime import datetime, timedelta, tzinfo
+from datetime import timedelta, tzinfo
 
 class UTCtzinfo(tzinfo):
     def utcoffset(self, dt):
diff --git a/tests/Traffic.py b/tests/Traffic.py
@@ -28,7 +28,6 @@
 
 import Framework
 
-import github
 import datetime
 
 class Traffic(Framework.TestCase):
