Backport to Python 2.2

dabrahams · dabrahams · commit bd0175c167e8 · 2002-10-04T13:05:57.000Z
[SVN r15706]
diff --git a/src/object/class.cpp b/src/object/class.cpp
@@ -330,7 +330,7 @@ namespace objects
     //             rest corresponding to its declared bases.
     //
     inline object
-    new_class(char const* name, std::size_t num_types, class_id const* const types)
+    new_class(char const* name, std::size_t num_types, class_id const* const types, char const* doc)
     {
       assert(num_types >= 1);
       
@@ -348,7 +348,12 @@ namespace objects
       }
 
       // Call the class metatype to create a new class
-      object result = object(class_metatype())(module_prefix() + name, bases, dict());
+      dict d;
+      
+      if (doc != 0)
+          d["__doc__"] = doc;
+      
+      object result = object(class_metatype())(module_prefix() + name, bases, d);
       assert(PyType_IsSubtype(result.ptr()->ob_type, &PyType_Type));
       
       if (scope().ptr() != Py_None)
@@ -360,17 +365,14 @@ namespace objects
   
   class_base::class_base(
       char const* name, std::size_t num_types, class_id const* const types, char const* doc)
-      : object(new_class(name, num_types, types))
+      : object(new_class(name, num_types, types, doc))
   {
       // Insert the new class object in the registry
       converter::registration& converters = const_cast<converter::registration&>(
           converter::registry::lookup(types[0]));
 
       // Class object is leaked, for now
       converters.class_object = (PyTypeObject*)incref(this->ptr());
-
-      if (doc)
-          this->attr("__doc__") = doc;
   }
 
   void class_base::set_instance_size(std::size_t instance_size)
diff --git a/test/defaults.py b/test/defaults.py
@@ -1,4 +1,6 @@
 """
+>>> False = 0 # Python 2.2 needs these
+>>> True = 1
 
 >>> from defaults_ext import *
 >>> bar(1)
