Assert refcount before decrement (boostorg#64)

WKarel · stefanseefeld · commit bc2f77a3db0b · 2016-09-29T07:48:46.000-04:00
Assert reference count before decrementing it.
diff --git a/include/boost/python/object_core.hpp b/include/boost/python/object_core.hpp
@@ -422,6 +422,7 @@ inline api::object_base& api::object_base::operator=(api::object_base const& rhs
 
 inline api::object_base::~object_base()
 {
+    assert( Py_REFCNT(m_ptr) > 0 );
     Py_DECREF(m_ptr);
 }
 
diff --git a/include/boost/python/refcount.hpp b/include/boost/python/refcount.hpp
@@ -27,12 +27,14 @@ inline T* xincref(T* p)
 template <class T>
 inline void decref(T* p)
 {
+    assert( Py_REFCNT(python::upcast<PyObject>(p)) > 0 );
     Py_DECREF(python::upcast<PyObject>(p));
 }
 
 template <class T>
 inline void xdecref(T* p)
 {
+    assert( !p || Py_REFCNT(python::upcast<PyObject>(p)) > 0 );
     Py_XDECREF(python::upcast<PyObject>(p));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -422,6 +422,7 @@ inline api::object_base& api::object_base::operator=(api::object_base const& rhs`
`422`	`422`
`423`	`423`	`inline api::object_base::~object_base()`
`424`	`424`	`{`
	`425`	`+ assert( Py_REFCNT(m_ptr) > 0 );`
`425`	`426`	`Py_DECREF(m_ptr);`
`426`	`427`	`}`
`427`	`428`
Original file line number	Diff line number	Diff line change
`@@ -27,12 +27,14 @@ inline T* xincref(T* p)`
`27`	`27`	`template <class T>`
`28`	`28`	`inline void decref(T* p)`
`29`	`29`	`{`
	`30`	`+ assert( Py_REFCNT(python::upcast<PyObject>(p)) > 0 );`
`30`	`31`	`Py_DECREF(python::upcast<PyObject>(p));`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`template <class T>`
`34`	`35`	`inline void xdecref(T* p)`
`35`	`36`	`{`
	`37`	`+ assert( !p \|\| Py_REFCNT(python::upcast<PyObject>(p)) > 0 );`
`36`	`38`	`Py_XDECREF(python::upcast<PyObject>(p));`
`37`	`39`	`}`
`38`	`40`