consistent use of get_pointer

dabrahams · dabrahams · commit 48321857e406 · 2003-12-18T19:23:38.000Z
[SVN r21326]
diff --git a/include/boost/python/object/make_ptr_instance.hpp b/include/boost/python/object/make_ptr_instance.hpp
@@ -49,19 +49,15 @@ struct make_ptr_instance
     template <class U>
     static inline PyTypeObject* get_derived_class_object(mpl::true_, U const volatile* x)
     {
-        converter::registration const* r = converter::registry::query(type_info(typeid(*x)));
+        converter::registration const* r = converter::registry::query(
+            type_info(typeid(*get_pointer(x)))
+        );
         return r ? r->m_class_object : 0;
     }
     
     template <class U>
-    static inline PyTypeObject* get_derived_class_object(mpl::false_, U* x)
+    static inline PyTypeObject* get_derived_class_object(mpl::false_, U*)
     {
-# if BOOST_WORKAROUND(__MWERKS__, <= 0x2407)
-        if (typeid(*x) != typeid(U))
-            return get_derived_class_object(mpl::true_(), x);
-# else
-        (void)x;
-# endif 
         return 0;
     }
 };
diff --git a/include/boost/python/object/pointer_holder.hpp b/include/boost/python/object/pointer_holder.hpp
@@ -104,11 +104,11 @@ void* pointer_holder<Pointer, Value>::holds(type_info dst_t)
     if (dst_t == python::type_id<Pointer>())
         return &this->m_p;
 
-    if (get_pointer(this->m_p) == 0)
+    Value* p = get_pointer(this->m_p);
+    if (p == 0)
         return 0;
     
     type_info src_t = python::type_id<Value>();
-    Value* p = &*this->m_p;
     return src_t == dst_t ? p : find_dynamic_type(p, src_t, dst_t);
 }
 
@@ -121,11 +121,12 @@ void* pointer_holder_back_reference<Pointer, Value>::holds(type_info dst_t)
     if (!get_pointer(this->m_p))
         return 0;
     
+    Value* p = get_pointer(m_p);
+    
     if (dst_t == python::type_id<held_type>())
-        return &*this->m_p;
+        return p;
 
     type_info src_t = python::type_id<Value>();
-    Value* p = &*this->m_p;
     return src_t == dst_t ? p : find_dynamic_type(p, src_t, dst_t);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,19 +49,15 @@ struct make_ptr_instance`
`49`	`49`	`template <class U>`
`50`	`50`	`static inline PyTypeObject* get_derived_class_object(mpl::true_, U const volatile* x)`
`51`	`51`	`{`
`52`		`- converter::registration const* r = converter::registry::query(type_info(typeid(*x)));`
	`52`	`+ converter::registration const* r = converter::registry::query(`
	`53`	`+ type_info(typeid(*get_pointer(x)))`
	`54`	`+ );`
`53`	`55`	`return r ? r->m_class_object : 0;`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`template <class U>`
`57`		`- static inline PyTypeObject* get_derived_class_object(mpl::false_, U* x)`
	`59`	`+ static inline PyTypeObject* get_derived_class_object(mpl::false_, U*)`
`58`	`60`	`{`
`59`		`-# if BOOST_WORKAROUND(__MWERKS__, <= 0x2407)`
`60`		`- if (typeid(*x) != typeid(U))`
`61`		`- return get_derived_class_object(mpl::true_(), x);`
`62`		`-# else`
`63`		`- (void)x;`
`64`		`-# endif`
`65`	`61`	`return 0;`
`66`	`62`	`}`
`67`	`63`	`};`