Silence potentially upcoming circular dependency warning (#973)

addaleax · nfischer · commit 05374a749992 · 2019-10-20T15:17:10.000-07:00
Node.js is currently considering printing a warning when a non-existent property of `module.exports` is accessed while in a circular `require()` dependency, in order to make it easier to catch issues with circular dependencies. In order to avoid printing these warnings for shelljs, checking for the property’s existence rather than its truthiness suffices. Refs: nodejs/node#29935
diff --git a/src/common.js b/src/common.js
@@ -478,7 +478,7 @@ function _register(name, implementation, wrapOptions) {
   // If an option isn't specified, use the default
   wrapOptions = Object.assign({}, DEFAULT_WRAP_OPTIONS, wrapOptions);
 
-  if (shell[name]) {
+  if (shell.hasOwnProperty(name)) {
     throw new Error('Command `' + name + '` already exists');
   }
 

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,7 @@ function _register(name, implementation, wrapOptions) {`
`478`	`478`	`// If an option isn't specified, use the default`
`479`	`479`	`wrapOptions = Object.assign({}, DEFAULT_WRAP_OPTIONS, wrapOptions);`
`480`	`480`
`481`		`- if (shell[name]) {`
	`481`	`+ if (shell.hasOwnProperty(name)) {`
`482`	`482`	throw new Error('Command `' + name + '` already exists');
`483`	`483`	`}`
`484`	`484`