Remove Copy from PyPayload

youknowone · web-flow · commit e0e29260f510 · 2026-01-24T22:03:30.000+09:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -222,7 +222,6 @@ wasm-bindgen = "0.2.106"
 unsafe_code = "allow"
 unsafe_op_in_unsafe_fn = "deny"
 elided_lifetimes_in_paths = "warn"
-missing_copy_implementations = "warn"
 
 [workspace.lints.clippy]
 # alloc_instead_of_core = "warn"
diff --git a/crates/vm/src/anystr.rs b/crates/vm/src/anystr.rs
@@ -16,13 +16,13 @@ pub struct SplitArgs<T: TryFromObject> {
     maxsplit: isize,
 }
 
-#[derive(Clone, Copy, FromArgs)]
+#[derive(FromArgs)]
 pub struct SplitLinesArgs {
     #[pyarg(any, default = false)]
     pub keepends: bool,
 }
 
-#[derive(Clone, Copy, FromArgs)]
+#[derive(FromArgs)]
 pub struct ExpandTabsArgs {
     #[pyarg(any, default = 8)]
     tabsize: isize,
diff --git a/crates/vm/src/builtins/descriptor.rs b/crates/vm/src/builtins/descriptor.rs
@@ -168,21 +168,19 @@ impl Representable for PyMethodDescriptor {
     }
 }
 
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub enum MemberKind {
     Bool = 14,
     ObjectEx = 16,
 }
 
 pub type MemberSetterFunc = Option<fn(&VirtualMachine, PyObjectRef, PySetterValue) -> PyResult<()>>;
 
-#[derive(Clone, Copy)]
 pub enum MemberGetter {
     Getter(fn(&VirtualMachine, PyObjectRef) -> PyResult),
     Offset(usize),
 }
 
-#[derive(Clone, Copy)]
 pub enum MemberSetter {
     Setter(MemberSetterFunc),
     Offset(usize),
diff --git a/crates/vm/src/builtins/module.rs b/crates/vm/src/builtins/module.rs
@@ -9,7 +9,7 @@ use crate::{
 };
 
 #[pyclass(module = false, name = "module")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct PyModuleDef {
     // pub index: usize,
     pub name: &'static PyStrInterned,
@@ -26,7 +26,7 @@ pub type ModuleCreate =
     fn(&VirtualMachine, &PyObject, &'static PyModuleDef) -> PyResult<PyRef<PyModule>>;
 pub type ModuleExec = fn(&VirtualMachine, &Py<PyModule>) -> PyResult<()>;
 
-#[derive(Clone, Copy, Default)]
+#[derive(Default)]
 pub struct PyModuleSlots {
     pub create: Option<ModuleCreate>,
     pub exec: Option<ModuleExec>,
@@ -83,7 +83,7 @@ impl PyModuleDef {
 
 #[allow(clippy::new_without_default)] // avoid Default implementation
 #[pyclass(module = false, name = "module")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct PyModule {
     // PyObject *md_dict;
     pub def: Option<&'static PyModuleDef>,
diff --git a/crates/vm/src/builtins/namespace.rs b/crates/vm/src/builtins/namespace.rs
@@ -14,8 +14,8 @@ use crate::{
 ///
 /// SimpleNamespace(**kwargs)
 #[pyclass(module = "types", name = "SimpleNamespace")]
-#[derive(Copy, Clone, Debug, Default)]
-pub struct PyNamespace;
+#[derive(Debug, Default)]
+pub struct PyNamespace {}
 
 impl PyPayload for PyNamespace {
     #[inline]
diff --git a/crates/vm/src/builtins/object.rs b/crates/vm/src/builtins/object.rs
@@ -18,7 +18,7 @@ use itertools::Itertools;
 /// When called, it accepts no arguments and returns a new featureless
 /// instance that has no instance attributes and cannot be given any.
 #[pyclass(module = false, name = "object")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct PyBaseObject;
 
 impl PyPayload for PyBaseObject {
diff --git a/crates/vm/src/builtins/singletons.rs b/crates/vm/src/builtins/singletons.rs
@@ -9,7 +9,7 @@ use crate::{
 };
 
 #[pyclass(module = false, name = "NoneType")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct PyNone;
 
 impl PyPayload for PyNone {
@@ -75,7 +75,7 @@ impl AsNumber for PyNone {
 }
 
 #[pyclass(module = false, name = "NotImplementedType")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct PyNotImplemented;
 
 impl PyPayload for PyNotImplemented {
diff --git a/crates/vm/src/builtins/slice.rs b/crates/vm/src/builtins/slice.rs
@@ -301,7 +301,7 @@ impl Representable for PySlice {
 }
 
 #[pyclass(module = false, name = "EllipsisType")]
-#[derive(Copy, Clone, Debug)]
+#[derive(Debug)]
 pub struct PyEllipsis;
 
 impl PyPayload for PyEllipsis {
diff --git a/crates/vm/src/builtins/zip.rs b/crates/vm/src/builtins/zip.rs
@@ -24,7 +24,7 @@ impl PyPayload for PyZip {
     }
 }
 
-#[derive(Clone, Copy, FromArgs)]
+#[derive(FromArgs)]
 pub struct PyZipNewArgs {
     #[pyarg(named, optional)]
     strict: OptionalArg<bool>,
diff --git a/crates/vm/src/dict_inner.rs b/crates/vm/src/dict_inner.rs
@@ -124,7 +124,7 @@ struct DictEntry<T> {
 }
 static_assertions::assert_eq_size!(DictEntry<PyObjectRef>, Option<DictEntry<PyObjectRef>>);
 
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
+#[derive(Debug, PartialEq, Eq)]
 pub struct DictSize {
     indices_size: usize,
     pub entries_size: usize,
diff --git a/crates/vm/src/function/method.rs b/crates/vm/src/function/method.rs
@@ -63,7 +63,7 @@ macro_rules! define_methods {
     };
 }
 
-#[derive(Clone, Copy)]
+#[derive(Clone)]
 pub struct PyMethodDef {
     pub name: &'static str, // TODO: interned
     pub func: &'static dyn PyNativeFn,
@@ -270,7 +270,7 @@ impl core::fmt::Debug for PyMethodDef {
 // This is not a part of CPython API.
 // But useful to support dynamically generated methods
 #[pyclass(name, module = false, ctx = "method_def")]
-#[derive(Clone, Copy, Debug)]
+#[derive(Debug)]
 pub struct HeapMethodDef {
     method: PyMethodDef,
 }
diff --git a/crates/vm/src/function/number.rs b/crates/vm/src/function/number.rs
@@ -14,7 +14,7 @@ use num_traits::PrimInt;
 /// method, this method will first be called to convert the object into a float.
 /// If `__complex__()` is not defined then it falls back to `__float__()`. If
 /// `__float__()` is not defined it falls back to `__index__()`.
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Debug, PartialEq)]
 #[repr(transparent)]
 pub struct ArgIntoComplex {
     value: Complex64,
@@ -52,7 +52,7 @@ impl TryFromObject for ArgIntoComplex {
 /// If the object is not a Python floating point object but has a `__float__()`
 /// method, this method will first be called to convert the object into a float.
 /// If `__float__()` is not defined then it falls back to `__index__()`.
-#[derive(Clone, Copy, Debug, PartialEq)]
+#[derive(Debug, PartialEq)]
 #[repr(transparent)]
 pub struct ArgIntoFloat {
     value: f64,
@@ -95,7 +95,7 @@ impl TryFromObject for ArgIntoFloat {
 /// By default an object is considered true unless its class defines either a
 /// `__bool__()` method that returns False or a `__len__()` method that returns
 /// zero, when called with the object.
-#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
+#[derive(Debug, Default, PartialEq, Eq)]
 pub struct ArgIntoBool {
     value: bool,
 }
diff --git a/crates/vm/src/protocol/buffer.rs b/crates/vm/src/protocol/buffer.rs
@@ -14,7 +14,6 @@ use alloc::borrow::Cow;
 use core::{fmt::Debug, ops::Range};
 use itertools::Itertools;
 
-#[derive(Clone, Copy)]
 pub struct BufferMethods {
     pub obj_bytes: fn(&PyBuffer) -> BorrowedValue<'_, [u8]>,
     pub obj_bytes_mut: fn(&PyBuffer) -> BorrowedValueMut<'_, [u8]>,
diff --git a/crates/vm/src/protocol/mapping.rs b/crates/vm/src/protocol/mapping.rs
@@ -48,7 +48,7 @@ impl PyMappingSlots {
 }
 
 #[allow(clippy::type_complexity)]
-#[derive(Clone, Copy, Default)]
+#[derive(Default)]
 pub struct PyMappingMethods {
     pub length: Option<fn(PyMapping<'_>, &VirtualMachine) -> PyResult<usize>>,
     pub subscript: Option<fn(PyMapping<'_>, &PyObject, &VirtualMachine) -> PyResult>,
diff --git a/crates/vm/src/protocol/sequence.rs b/crates/vm/src/protocol/sequence.rs
@@ -70,7 +70,7 @@ impl PySequenceSlots {
 }
 
 #[allow(clippy::type_complexity)]
-#[derive(Clone, Copy, Default)]
+#[derive(Default)]
 pub struct PySequenceMethods {
     pub length: Option<fn(PySequence<'_>, &VirtualMachine) -> PyResult<usize>>,
     pub concat: Option<fn(PySequence<'_>, &PyObject, &VirtualMachine) -> PyResult>,
diff --git a/crates/vm/src/sliceable.rs b/crates/vm/src/sliceable.rs
@@ -252,7 +252,6 @@ impl<T: Clone> SliceableSequenceOp for [T] {
     }
 }
 
-#[derive(Clone, Copy)]
 pub enum SequenceIndex {
     Int(isize),
     Slice(SaturatedSlice),
@@ -404,7 +403,6 @@ impl SaturatedSlice {
     }
 }
 
-#[derive(Clone, Copy)]
 pub struct SaturatedSliceIter {
     index: isize,
     step: isize,
diff --git a/crates/vm/src/stdlib/marshal.rs b/crates/vm/src/stdlib/marshal.rs
@@ -25,7 +25,6 @@ mod decl {
     #[pyattr(name = "version")]
     use marshal::FORMAT_VERSION;
 
-    #[derive(Clone, Copy)]
     pub struct DumpError;
 
     impl marshal::Dumpable for PyObjectRef {
diff --git a/crates/vm/src/stdlib/os.rs b/crates/vm/src/stdlib/os.rs
@@ -35,7 +35,7 @@ impl crate::convert::IntoPyException for rustix::io::Errno {
 }
 
 #[allow(dead_code)]
-#[derive(FromArgs, Default, Copy, Clone)]
+#[derive(FromArgs, Default)]
 pub struct TargetIsDirectory {
     #[pyarg(any, default = false)]
     pub(crate) target_is_directory: bool,
diff --git a/crates/vm/src/stdlib/typevar.rs b/crates/vm/src/stdlib/typevar.rs
@@ -988,7 +988,7 @@ pub(crate) mod typevar {
 
     #[pyattr]
     #[pyclass(name = "Generic", module = "typing")]
-    #[derive(Copy, Clone, Debug, PyPayload)]
+    #[derive(Debug, PyPayload)]
     #[allow(dead_code)]
     pub struct Generic;
 
diff --git a/crates/vm/src/stdlib/typing.rs b/crates/vm/src/stdlib/typing.rs
@@ -49,7 +49,7 @@ pub(crate) mod decl {
     }
 
     #[pyclass(no_attr, name = "NoDefaultType", module = "typing")]
-    #[derive(Clone, Copy, Debug, PyPayload)]
+    #[derive(Debug, PyPayload)]
     pub struct NoDefault;
 
     #[pyclass(with(Constructor, Representable), flags(BASETYPE))]

Original file line number	Diff line number	Diff line change
`@@ -16,13 +16,13 @@ pub struct SplitArgs<T: TryFromObject> {`
`16`	`16`	`maxsplit: isize,`
`17`	`17`	`}`
`18`	`18`
`19`		`-#[derive(Clone, Copy, FromArgs)]`
	`19`	`+#[derive(FromArgs)]`
`20`	`20`	`pub struct SplitLinesArgs {`
`21`	`21`	`#[pyarg(any, default = false)]`
`22`	`22`	`pub keepends: bool,`
`23`	`23`	`}`
`24`	`24`
`25`		`-#[derive(Clone, Copy, FromArgs)]`
	`25`	`+#[derive(FromArgs)]`
`26`	`26`	`pub struct ExpandTabsArgs {`
`27`	`27`	`#[pyarg(any, default = 8)]`
`28`	`28`	`tabsize: isize,`
Original file line number	Diff line number	Diff line change
`@@ -168,21 +168,19 @@ impl Representable for PyMethodDescriptor {`
`168`	`168`	`}`
`169`	`169`	`}`
`170`	`170`
`171`		`-#[derive(Clone, Copy, Debug)]`
	`171`	`+#[derive(Debug)]`
`172`	`172`	`pub enum MemberKind {`
`173`	`173`	`Bool = 14,`
`174`	`174`	`ObjectEx = 16,`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`pub type MemberSetterFunc = Option<fn(&VirtualMachine, PyObjectRef, PySetterValue) -> PyResult<()>>;`
`178`	`178`
`179`		`-#[derive(Clone, Copy)]`
`180`	`179`	`pub enum MemberGetter {`
`181`	`180`	`Getter(fn(&VirtualMachine, PyObjectRef) -> PyResult),`
`182`	`181`	`Offset(usize),`
`183`	`182`	`}`
`184`	`183`
`185`		`-#[derive(Clone, Copy)]`
`186`	`184`	`pub enum MemberSetter {`
`187`	`185`	`Setter(MemberSetterFunc),`
`188`	`186`	`Offset(usize),`
Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ impl Representable for PySlice {`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`#[pyclass(module = false, name = "EllipsisType")]`
`304`		`-#[derive(Copy, Clone, Debug)]`
	`304`	`+#[derive(Debug)]`
`305`	`305`	`pub struct PyEllipsis;`
`306`	`306`
`307`	`307`	`impl PyPayload for PyEllipsis {`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ impl PyPayload for PyZip {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-#[derive(Clone, Copy, FromArgs)]`
	`27`	`+#[derive(FromArgs)]`
`28`	`28`	`pub struct PyZipNewArgs {`
`29`	`29`	`#[pyarg(named, optional)]`
`30`	`30`	`strict: OptionalArg<bool>,`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ struct DictEntry<T> {`
`124`	`124`	`}`
`125`	`125`	`static_assertions::assert_eq_size!(DictEntry<PyObjectRef>, Option<DictEntry<PyObjectRef>>);`
`126`	`126`
`127`		`-#[derive(Clone, Copy, Debug, PartialEq, Eq)]`
	`127`	`+#[derive(Debug, PartialEq, Eq)]`
`128`	`128`	`pub struct DictSize {`
`129`	`129`	`indices_size: usize,`
`130`	`130`	`pub entries_size: usize,`