Fix pow() raising ValueError instead of TypeError for non-int exponent (RustPython#7725)

jseop-lim · web-flow · commit c8ddbd232658 · 2026-04-29T18:18:11.000+09:00
* Validate pow() exponent type before zero-modulus check

* Add tests for pow() exponent type check
diff --git a/crates/vm/src/builtins/int.rs b/crates/vm/src/builtins/int.rs
@@ -395,6 +395,9 @@ impl PyInt {
     }
 
     fn modpow(&self, other: PyObjectRef, modulus: PyObjectRef, vm: &VirtualMachine) -> PyResult {
+        if other.downcast_ref::<Self>().is_none() {
+            return Ok(vm.ctx.not_implemented());
+        }
         let modulus = match modulus.downcast_ref::<Self>() {
             Some(val) => val.as_bigint(),
             None => return Ok(vm.ctx.not_implemented()),
diff --git a/extra_tests/snippets/builtin_pow.py b/extra_tests/snippets/builtin_pow.py
@@ -22,6 +22,9 @@
 assert pow(2, -1, 5) == 3
 assert_raises(ValueError, pow, 2, 2, 0)
 
+assert_raises(TypeError, pow, 1, None, 0)
+assert_raises(TypeError, pow, True, 1.5, False)
+
 
 assert_almost_equal = assert_equal
 

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,9 @@ impl PyInt {`
`395`	`395`	`}`
`396`	`396`
`397`	`397`	`fn modpow(&self, other: PyObjectRef, modulus: PyObjectRef, vm: &VirtualMachine) -> PyResult {`
	`398`	`+ if other.downcast_ref::<Self>().is_none() {`
	`399`	`+ return Ok(vm.ctx.not_implemented());`
	`400`	`+ }`
`398`	`401`	`let modulus = match modulus.downcast_ref::<Self>() {`
`399`	`402`	`Some(val) => val.as_bigint(),`
`400`	`403`	`None => return Ok(vm.ctx.not_implemented()),`