network: fix assorted list of minor bugs

yadvr · yadvr · commit cfb3194bbf8c · 2021-01-20T07:06:18.000+05:30
- Show the VPN tab only for sourcenat IPs
- Go back on archiving alerts
- Show PF, LB tabs for IPs on VPCs

Signed-off-by: Rohit Yadav &lt;rohit.yadav@shapeblue.com&gt;
diff --git a/ui/src/components/view/ListView.vue b/ui/src/components/view/ListView.vue
@@ -23,7 +23,7 @@
     :dataSource="items"
     :rowKey="record => record.id || record.name"
     :pagination="false"
-    :rowSelection="['vm', 'event', 'alert'].includes($route.name) ? {selectedRowKeys: selectedRowKeys, onChange: onSelectChange} : null"
+    :rowSelection="['vm-tbd', 'event-tbd', 'alert-tbd'].includes($route.name) ? {selectedRowKeys: selectedRowKeys, onChange: onSelectChange} : null"
     :rowClassName="getRowClassName"
     style="overflow-y: auto"
   >
diff --git a/ui/src/components/view/ResourceView.vue b/ui/src/components/view/ResourceView.vue
@@ -107,7 +107,12 @@ export default {
     },
     showHideTab (tab) {
       if ('networkServiceFilter' in tab) {
-        if (this.resource.virtualmachineid && tab.name !== 'Firewall') return false
+        if (this.resource.virtualmachineid && tab.name !== 'Firewall') {
+          return false
+        }
+        if (this.resource && this.resource.vpcid && tab.name !== 'Firewall') {
+          return true
+        }
         return this.networkService && this.networkService.service &&
           tab.networkServiceFilter(this.networkService.service)
       } else if ('show' in tab) {
diff --git a/ui/src/config/section/network.js b/ui/src/config/section/network.js
@@ -214,7 +214,8 @@ export default {
         networkServiceFilter: networkService => networkService.filter(x => x.name === 'Lb').length > 0
       }, {
         name: 'VPN',
-        component: () => import('@/views/network/VpnDetails.vue')
+        component: () => import('@/views/network/VpnDetails.vue'),
+        show: (record) => { return record.issourcenat }
       }],
       actions: [
         {
diff --git a/ui/src/views/AutogenView.vue b/ui/src/views/AutogenView.vue
@@ -781,7 +781,7 @@ export default {
                 break
               }
             }
-            if ((this.currentAction.icon === 'delete' || ['archiveEvents'].includes(this.currentAction.api)) && this.dataView) {
+            if ((this.currentAction.icon === 'delete' || ['archiveEvents', 'archiveAlerts'].includes(this.currentAction.api)) && this.dataView) {
               this.$router.go(-1)
             } else {
               if (!hasJobId) {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`:dataSource="items"`
`24`	`24`	`:rowKey="record => record.id \|\| record.name"`
`25`	`25`	`:pagination="false"`
`26`		`- :rowSelection="['vm', 'event', 'alert'].includes($route.name) ? {selectedRowKeys: selectedRowKeys, onChange: onSelectChange} : null"`
	`26`	`+ :rowSelection="['vm-tbd', 'event-tbd', 'alert-tbd'].includes($route.name) ? {selectedRowKeys: selectedRowKeys, onChange: onSelectChange} : null"`
`27`	`27`	`:rowClassName="getRowClassName"`
`28`	`28`	`style="overflow-y: auto"`
`29`	`29`	`>`
Original file line number	Diff line number	Diff line change
`@@ -781,7 +781,7 @@ export default {`
`781`	`781`	`break`
`782`	`782`	`}`
`783`	`783`	`}`
`784`		`- if ((this.currentAction.icon === 'delete' \|\| ['archiveEvents'].includes(this.currentAction.api)) && this.dataView) {`
	`784`	`+ if ((this.currentAction.icon === 'delete' \|\| ['archiveEvents', 'archiveAlerts'].includes(this.currentAction.api)) && this.dataView) {`
`785`	`785`	`this.$router.go(-1)`
`786`	`786`	`} else {`
`787`	`787`	`if (!hasJobId) {`