CLOUDSTACK-7581: Empty 'ID' parameters allowed in API calls

koushik-das · koushik-das · commit 4e07dd1dc4b4 · 2014-09-18T17:10:25.000+05:30
Fix is to fail API calls with empty 'id' parameter value upfront rather than going ahead and failing with NPE later on
diff --git a/server/src/com/cloud/api/dispatch/ParamProcessWorker.java b/server/src/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -329,8 +329,6 @@ private void setFieldValue(final Field field, final BaseCmd cmdObj, final Object
                     field.set(cmdObj, listParam);
                     break;
                 case UUID:
-                    if (paramObj.toString().isEmpty())
-                        break;
                     final Long internalId = translateUuidToInternalId(paramObj.toString(), annotation);
                     field.set(cmdObj, internalId);
                     break;
