Skip to content

Commit 2db078a

Browse files
author
Jessica Wang
committed
bug 4556: localize middle menu actions.
1 parent 38857cf commit 2db078a

3 files changed

Lines changed: 14 additions & 5 deletions

File tree

client/WEB-INF/classes/resources/messages.properties

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ label.add=Add
1919
label.adding.processing=Adding....
2020
label.adding.succeeded=Adding Succeeded
2121
label.adding.failed=Adding Failed
22+
label.succeeded=Succeeded
23+
label.failed=Failed
24+
label.error.code=Error Code
2225
label.add.zone=Add Zone
2326
label.adding.zone=Adding Zone
2427
label.add.host=Add Host

ui/index.jsp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,10 @@
6767
g_dictionary = {
6868
'label.adding.processing' : '<fmt:message key="label.adding.processing"/>',
6969
'label.adding.succeeded' : '<fmt:message key="label.adding.succeeded"/>',
70-
'label.adding.failed' : '<fmt:message key="label.adding.failed"/>'
70+
'label.adding.failed' : '<fmt:message key="label.adding.failed"/>',
71+
'label.succeeded' : '<fmt:message key="label.succeeded"/>',
72+
'label.failed' : '<fmt:message key="label.failed"/>',
73+
'label.error.code': '<fmt:message key="label.error.code"/>'
7174
};
7275
</script>
7376
</head>

ui/scripts/cloud.core.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -410,12 +410,14 @@ function doActionToMidMenu(id, apiInfo, apiCommand) {
410410
$midmenuItem1.find("#content").removeClass("inaction");
411411
$midmenuItem1.find("#spinning_wheel").hide();
412412
hideDetailsTabActionSpinningWheel(id, inProcessText2, $midmenuItem1);
413+
413414
if (result.jobstatus == 1) { // Succeeded
414415
$midmenuItem1.find("#info_icon").removeClass("error").show();
415-
$midmenuItem1.data("afterActionInfo", (label2 + " action succeeded."));
416+
$midmenuItem1.data("afterActionInfo", (label2 + " - " + g_dictionary["label.succeeded"]));
416417
afterActionSeccessFn(json, $midmenuItem1, id);
417418
} else if (result.jobstatus == 2) { // Failed
418-
var errorMsg = label2 + " action failed. Reason: " + fromdb(result.jobresult.errortext);
419+
//var errorMsg = label2 + " action failed. Reason: " + fromdb(result.jobresult.errortext);
420+
var errorMsg = label2 + " - " + g_dictionary["label.failed"] + " - " + g_dictionary["label.error.code"] + " " + fromdb(result.jobresult.errorcode);
419421
handleErrorInMidMenu2(errorMsg, $midmenuItem1, id, inProcessText2);
420422
}
421423
}
@@ -447,7 +449,8 @@ function doActionToMidMenu(id, apiInfo, apiCommand) {
447449
$midmenuItem1.find("#content").removeClass("inaction");
448450
$midmenuItem1.find("#spinning_wheel").hide();
449451
$midmenuItem1.find("#info_icon").removeClass("error").show();
450-
$midmenuItem1.data("afterActionInfo", (label2 + " action succeeded."));
452+
//$midmenuItem1.data("afterActionInfo", (label2 + " action succeeded."));
453+
$midmenuItem1.data("afterActionInfo", (label2 + " - " + g_dictionary["label.succeeded"]));
451454
hideDetailsTabActionSpinningWheel(id, inProcessText2, $midmenuItem1);
452455
afterActionSeccessFn(json, $midmenuItem1, id);
453456
},
@@ -529,7 +532,7 @@ function copyActionInfoFromMidMenuToRightPanel($midmenuItem1) {
529532
if(inProcessText in dictionary)
530533
$detailsTabSpinningWheel.find("#description").text(dictionary[inProcessText]);
531534
else
532-
$detailsTabSpinningWheel.find("#description").text(label);
535+
$detailsTabSpinningWheel.find("#description").text(inProcessText);
533536
$detailsTabSpinningWheel.show();
534537
}
535538
}

0 commit comments

Comments
 (0)