CLOUDSTACK-9686: Fixed multiple entires for builtin template in template

anshul-gangwar · Rohit Yadav · commit 16b67b40fd26 · 2017-08-01T20:40:25.000+02:00
store ref table so builtin template is never downloaded completely In handleSysTemplateDownload method creating template only if there exists no entry handleTemplateSync will take care of other scenario (cherry picked from commit 929595c) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
diff --git a/engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java b/engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
@@ -267,7 +267,7 @@ public void handleSysTemplateDownload(HypervisorType hostHyper, Long dcId) {
 
             for (VMTemplateVO template : toBeDownloaded) {
                 TemplateDataStoreVO tmpltHost = _vmTemplateStoreDao.findByStoreTemplate(store.getId(), template.getId());
-                if (tmpltHost == null || tmpltHost.getState() != ObjectInDataStoreStateMachine.State.Ready) {
+                if (tmpltHost == null) {
                     associateTemplateToZone(template.getId(), dcId);
                     s_logger.info("Downloading builtin template " + template.getUniqueName() + " to data center: " + dcId);
                     TemplateInfo tmplt = _templateFactory.getTemplate(template.getId(), DataStoreRole.Image);
