Router health check notification mail to show router name next to UUID (apache#6130)

DaanHoogland · Daan Hoogland · web-flow · commit 13efa5909794 · 2022-03-20T23:44:06.000-03:00
* alerrt message altered

* review feedback and format

Co-authored-by: Daan Hoogland &lt;dahn@onecht.net&gt;
diff --git a/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java b/server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
@@ -1215,7 +1215,7 @@ private void handleFailingChecks(DomainRouterVO router, List<String> failingChec
             return;
         }
 
-        String alertMessage = "Health checks failed: " + failingChecks.size() + " failing checks on router " + router.getUuid();
+        String alertMessage = String.format("Health checks failed: %d failing checks on router %s / %s", failingChecks.size(), router.getName(), router.getUuid());
         _alertMgr.sendAlert(AlertType.ALERT_TYPE_DOMAIN_ROUTER, router.getDataCenterId(), router.getPodIdToDeployIn(),
                 alertMessage, alertMessage);
         s_logger.warn(alertMessage + ". Checking failed health checks to see if router needs recreate");
@@ -1227,6 +1227,8 @@ private void handleFailingChecks(DomainRouterVO router, List<String> failingChec
             String failedCheck = failingChecks.get(i);
             if (i == 0) {
                 failingChecksEvent.append("Router ")
+                        .append(router.getName())
+                        .append(" / ")
                         .append(router.getUuid())
                         .append(" has failing checks: ");
             }
