Adds the ability to rename via the TypeInfo object (graphql-java#1538)

bbakerman · web-flow · commit f21015476e22 · 2019-05-15T12:45:53.000+10:00
diff --git a/src/main/java/graphql/schema/idl/TypeInfo.java b/src/main/java/graphql/schema/idl/TypeInfo.java
@@ -68,6 +68,31 @@ public boolean isPlain() {
         return !isList() && !isNonNull();
     }
 
+    /**
+     * This will rename the type with the specified new name but will preserve the wrapping that was present
+     *
+     * @param newName the new name of the type
+     *
+     * @return a new type info rebuilt with the new name
+     */
+    public TypeInfo renameAs(String newName) {
+
+        Type out = TypeName.newTypeName(newName).build();
+
+        Stack<Class<?>> wrappingStack = new Stack<>();
+        wrappingStack.addAll(this.decoration);
+        while (!wrappingStack.isEmpty()) {
+            Class<?> clazz = wrappingStack.pop();
+            if (clazz.equals(NonNullType.class)) {
+                out = NonNullType.newNonNullType(out).build();
+            }
+            if (clazz.equals(ListType.class)) {
+                out = ListType.newListType(out).build();
+            }
+        }
+        return typeInfo(out);
+    }
+
     /**
      * This will decorate a graphql type with the original hierarchy of non null and list'ness
      * it originally contained in its definition type
diff --git a/src/test/groovy/graphql/TestUtil.groovy b/src/test/groovy/graphql/TestUtil.groovy
@@ -5,7 +5,9 @@ import graphql.execution.MergedSelectionSet
 import graphql.introspection.Introspection.DirectiveLocation
 import graphql.language.Document
 import graphql.language.Field
+import graphql.language.ObjectTypeDefinition
 import graphql.language.ScalarTypeDefinition
+import graphql.language.Type
 import graphql.parser.Parser
 import graphql.schema.Coercing
 import graphql.schema.DataFetcher
@@ -209,6 +211,22 @@ class TestUtil {
         new Parser().parseDocument(query)
     }
 
+    static Type parseType(String typeAst) {
+        String docStr = """
+            type X {
+                field : $typeAst
+            }
+        """
+        try {
+            def document = toDocument(docStr)
+            ObjectTypeDefinition objTypeDef = document.getDefinitionsOfType(ObjectTypeDefinition.class)[0]
+            return objTypeDef.fieldDefinitions[0].getType()
+        } catch (Exception ignored) {
+            assert false, "Invalid type AST string : $typeAst"
+            return null
+        }
+    }
+
     static Document toDocument(String query) {
         parseQuery(query)
     }
diff --git a/src/test/groovy/graphql/schema/idl/TypeInfoTest.groovy b/src/test/groovy/graphql/schema/idl/TypeInfoTest.groovy
@@ -1,5 +1,7 @@
 package graphql.schema.idl
 
+import graphql.TestUtil
+import graphql.language.AstPrinter
 import graphql.language.ListType
 import graphql.language.NonNullType
 import graphql.language.Type
@@ -9,6 +11,7 @@ import graphql.schema.GraphQLNonNull
 import graphql.schema.GraphQLObjectType
 import graphql.schema.GraphQLType
 import spock.lang.Specification
+import spock.lang.Unroll
 
 class TypeInfoTest extends Specification {
 
@@ -112,4 +115,25 @@ class TypeInfoTest extends Specification {
         assertNotEqualsAndHashCode(new NonNullType(new ListType(new TypeName("A"))), new ListType(new TypeName("A")))
         assertNotEqualsAndHashCode(new NonNullType(new ListType(new TypeName("A"))), new NonNullType(new ListType(new TypeName("B"))))
     }
+
+
+    @Unroll
+    def "test rename works as expected"() {
+
+        expect:
+        Type actualType = TestUtil.parseType(actual)
+        def typeInfo = TypeInfo.typeInfo(actualType)
+        TypeInfo newTypeInfo = typeInfo.renameAs("newName")
+        def printed = AstPrinter.printAst(newTypeInfo.getRawType())
+        printed == expected
+
+        where:
+        actual        | expected
+        "named"       | "newName"
+        "named!"      | "newName!"
+        "[named]"     | "[newName]"
+        "[named!]"    | "[newName!]"
+        "[named!]!"   | "[newName!]!"
+        "[[named!]!]" | "[[newName!]!]"
+    }
 }
