update path to not be null and test to match (graphql-java#1526)

jmccaull · bbakerman · commit f0d288cf4e34 · 2019-05-14T14:57:05.000+10:00
diff --git a/src/main/java/graphql/execution/AbsoluteGraphQLError.java b/src/main/java/graphql/execution/AbsoluteGraphQLError.java
@@ -101,7 +101,7 @@ private List<Object> createAbsolutePath(ExecutionPath executionPath,
                     return path;
                 })
                 .map(Collections::unmodifiableList)
-                .orElse(null);
+                .orElse(executionPath.toList());
     }
 
     /**
diff --git a/src/test/groovy/graphql/execution/AbsoluteGraphQLErrorTest.groovy b/src/test/groovy/graphql/execution/AbsoluteGraphQLErrorTest.groovy
@@ -58,7 +58,7 @@ class AbsoluteGraphQLErrorTest extends Specification {
         error.getExtensions() == ["ext": true]
     }
 
-    def "constructor handles missing path as null"() {
+    def "constructor handles missing path"() {
         given:
 
         def field = Field.newField().name("test").sourceLocation(new SourceLocation(4, 5)).build()
@@ -79,7 +79,7 @@ class AbsoluteGraphQLErrorTest extends Specification {
 
         then:
 
-        error.getPath() == null
+        error.getPath() == ExecutionPath.fromList(["foo", "bar"]).toList()
     }
 
     def "when constructor receives empty path it should return the base field path"() {

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ private List<Object> createAbsolutePath(ExecutionPath executionPath,`
`101`	`101`	`return path;`
`102`	`102`	`})`
`103`	`103`	`.map(Collections::unmodifiableList)`
`104`		`- .orElse(null);`
	`104`	`+ .orElse(executionPath.toList());`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ class AbsoluteGraphQLErrorTest extends Specification {`
`58`	`58`	`error.getExtensions() == ["ext": true]`
`59`	`59`	`}`
`60`	`60`
`61`		`- def "constructor handles missing path as null"() {`
	`61`	`+ def "constructor handles missing path"() {`
`62`	`62`	`given:`
`63`	`63`
`64`	`64`	`def field = Field.newField().name("test").sourceLocation(new SourceLocation(4, 5)).build()`
`@@ -79,7 +79,7 @@ class AbsoluteGraphQLErrorTest extends Specification {`
`79`	`79`
`80`	`80`	`then:`
`81`	`81`
`82`		`- error.getPath() == null`
	`82`	`+ error.getPath() == ExecutionPath.fromList(["foo", "bar"]).toList()`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`def "when constructor receives empty path it should return the base field path"() {`