Refine build workflow

sebastianquek · sebastianquek · commit 30d11b7edfef · 2023-03-02T11:52:15.000+08:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -45,8 +45,8 @@ jobs:
           path: npm.zip
           retention-days: 1
 
-  smoke-tests:
-    name: "Smoke tests for different Node.js versions"
+  smoke-tests-esm:
+    name: "Smoke tests (ESM)"
     needs: build
     runs-on: ubuntu-22.04
     strategy:
@@ -70,9 +70,39 @@ jobs:
       - name: Unzip build files
         run: unzip npm.zip
 
-      - name: Run smoke tests (esm)
+      - name: Run smoke tests
         run: |
-          echo ${{ matrix.node-version >= 14 }}
           cd tests/smoke/esm
           npm i
-          npm run esm
+          npm start
+
+  smoke-tests-commonjs:
+    name: "Smoke tests (commonjs)"
+    needs: build
+    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        node-version: [7.x]
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v3
+
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          registry-url: 'https://registry.npmjs.org'
+
+      - name: Download build files
+        uses: actions/download-artifact@v3
+        with:
+          name: npm
+
+      - name: Unzip build files
+        run: unzip npm.zip
+
+      - name: Run smoke tests
+        run: |
+          cd tests/smoke/commonjs
+          npm i
+          npm start
