Skip to content

fix: rollback PR #13951 in v6#14004

Merged
ephys merged 1 commit into
v6from
ephys/v6-rollback-overload
Jan 25, 2022
Merged

fix: rollback PR #13951 in v6#14004
ephys merged 1 commit into
v6from
ephys/v6-rollback-overload

Conversation

@ephys
Copy link
Copy Markdown
Member

@ephys ephys commented Jan 24, 2022 •
edited
Loading

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Rollbacking changes from #13951 in v6. The change is still present in v7.
I'm opening a follow-up PR to document the breaking change in v7.

Closes #14003

@ephys ephys self-assigned this Jan 24, 2022
@ephys ephys mentioned this pull request Jan 24, 2022
Merged
2 tasks
@WikiRik
Copy link
Copy Markdown
Member

WikiRik commented Jan 24, 2022

@ephys I'll let you merge this yourself, but do note that it will trigger an automatic release

@ephys
Copy link
Copy Markdown
Member Author

ephys commented Jan 25, 2022

Sounds good
The only failing test is the old flaky mysql one. Let's publish that fix :)

@ephys ephys merged commit 1882f3c into v6 Jan 25, 2022
@ephys ephys deleted the ephys/v6-rollback-overload branch January 25, 2022 10:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 25, 2022

🎉 This PR is included in version 6.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

maramizo pushed a commit to maramizo/sequelize that referenced this pull request Jun 2, 2022
@ephys @maramizo
fix: rollback PR sequelize#13951 in v6 (sequelize#14004)
9fc4c81
aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
@ephys @aliatsis
fix: rollback PR sequelize#13951 in v6 (sequelize#14004)
2062f70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees

@ephys ephys

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ephys @WikiRik