Skip to content

fix(truncate): fix missing await in truncate all model with cascade (v6)#12664

Merged
papb merged 1 commit into
sequelize:v6from
bmeriaux:fix-truncate-all-v6
Sep 1, 2020
Merged

fix(truncate): fix missing await in truncate all model with cascade (v6)#12664
papb merged 1 commit into
sequelize:v6from
bmeriaux:fix-truncate-all-v6

Conversation

@bmeriaux
Copy link
Copy Markdown
Contributor

@bmeriaux bmeriaux commented Sep 1, 2020 •
edited by papb
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

fix(truncate): fix missing await in truncate all model with cascade (#12660 with fix only for v6)

@bmeriaux bmeriaux changed the title fix(truncate): fix missing await in truncate all model with cascade fix(truncate): fix missing await in truncate all model with cascade (v6) Sep 1, 2020
@bmeriaux bmeriaux mentioned this pull request Sep 1, 2020
Closed
6 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #12664 into v6 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v6   #12664      +/-   ##
==========================================
- Coverage   96.44%   96.42%   -0.03%     
==========================================
  Files          95       95              
  Lines        9162     9162              
==========================================
- Hits         8836     8834       -2     
- Misses        326      328       +2
Impacted Files Coverage Δ
lib/sequelize.js 95.87% <0.00%> (ø)
lib/dialects/postgres/connection-manager.js 94.40% <0.00%> (-1.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490db41...555e700. Read the comment docs.

papb
papb approved these changes Sep 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@papb papb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@papb papb merged commit 933b3f6 into sequelize:v6 Sep 1, 2020
@papb
Copy link
Copy Markdown
Member

papb commented Sep 1, 2020

For the record, as discussed, a more careful look with extra tests will be performed in #12660

@sushantdhiman
Copy link
Copy Markdown
Contributor

sushantdhiman commented Sep 1, 2020

🎉 This PR is included in version 6.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@papb papb papb approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmeriaux @papb @sushantdhiman