From 162d7e30d4b382be3966d910ccd8a7bba661c0c3 Mon Sep 17 00:00:00 2001 From: yothinix Date: Tue, 3 Oct 2017 22:22:51 +0700 Subject: [PATCH 1/2] Fix typography on mail helper refactor proposal --- proposals/mail-helper-refactor.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proposals/mail-helper-refactor.md b/proposals/mail-helper-refactor.md index 18b970ad0..2e16d12fd 100644 --- a/proposals/mail-helper-refactor.md +++ b/proposals/mail-helper-refactor.md @@ -80,7 +80,7 @@ global_substitutions = { '-time-': strftime("%Y-%m-%d %H:%M:%S", gmtime()) } msg = Mail(from_email=From('from@example.com', 'From Name'), - to_emails=tos, + to_emails=to_emails, subject=Subject('Hi -name-'), plain_text_content=PlainTextContent('Hello -name-, your github is -github-, email sent at -time-'), html_content=HtmlContent('Hello -name-, your github is here email sent at -time-'), @@ -105,7 +105,7 @@ import sendgrid from sendgrid.helpers.mail import * msg = Mail(from_email=From('from@example.com', 'From Name'), - to_email=To('to@example.com', 'To Name'), + to_emails=To('to@example.com', 'To Name'), subject=Subject('Sending with SendGrid is Fun'), plain_text_content=PlainTextContent('and easy to do anywhere, even with Python'), html_content=HtmlContent('and easy to do anywhere, even with Python')) @@ -175,7 +175,7 @@ msg.bcc = [ msg.header = Header('X-Test5', 'Test5', p=1) msg.header = Header('X-Test6', 'Test6', p=1) -msg.headers = [ +msg.header = [ Header('X-Test7', 'Test7', p=1), Header('X-Test8', 'Test8', p=1) ] @@ -228,7 +228,7 @@ msg.attachment = [ msg.template_id = TemplateId('13b8f94f-bcae-4ec6-b752-70d6cb59f932') msg.global_header = Header('X-Day', 'Monday') -msg.global_headers = [ +msg.global_header = [ Header('X-Month', 'January'), Header('X-Year': '2017') ] From f01124e26dc76a493187c0e5516821db99b7c4f0 Mon Sep 17 00:00:00 2001 From: yothinix Date: Fri, 8 Dec 2017 21:17:32 +0700 Subject: [PATCH 2/2] Change back to plural as comment --- proposals/mail-helper-refactor.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proposals/mail-helper-refactor.md b/proposals/mail-helper-refactor.md index 2e16d12fd..c5f674fae 100644 --- a/proposals/mail-helper-refactor.md +++ b/proposals/mail-helper-refactor.md @@ -105,7 +105,7 @@ import sendgrid from sendgrid.helpers.mail import * msg = Mail(from_email=From('from@example.com', 'From Name'), - to_emails=To('to@example.com', 'To Name'), + to_email=To('to@example.com', 'To Name'), subject=Subject('Sending with SendGrid is Fun'), plain_text_content=PlainTextContent('and easy to do anywhere, even with Python'), html_content=HtmlContent('and easy to do anywhere, even with Python')) @@ -175,7 +175,7 @@ msg.bcc = [ msg.header = Header('X-Test5', 'Test5', p=1) msg.header = Header('X-Test6', 'Test6', p=1) -msg.header = [ +msg.headers = [ Header('X-Test7', 'Test7', p=1), Header('X-Test8', 'Test8', p=1) ] @@ -228,7 +228,7 @@ msg.attachment = [ msg.template_id = TemplateId('13b8f94f-bcae-4ec6-b752-70d6cb59f932') msg.global_header = Header('X-Day', 'Monday') -msg.global_header = [ +msg.global_headers = [ Header('X-Month', 'January'), Header('X-Year': '2017') ]