Skip to content

Commit 6bcb736

Browse files
committed
Add need for case to LogReader to the add new IO docs
1 parent cdc5254 commit 6bcb736

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

doc/internal-api.rst

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,15 @@ Ideally add both reading and writing support for the new file format, although t
9090
Besides from a constructor, only ``__iter__(self)`` needs to be implemented.
9191
3. Implement a writer ``CanstoreWriter`` (which often extends :class:`can.io.generic.BaseIOHandler` and :class:`can.Listener`, but does not have to).
9292
Besides from a constructor, only ``on_message_received(self, msg)`` needs to be implemented.
93-
4. Document the two new classes (and possibly additional helpers) with docstrings and comments.
93+
4. Add a case to ``can.io.player.LogReader``'s ``__new__()``.
94+
5. Document the two new classes (and possibly additional helpers) with docstrings and comments.
9495
Please mention features and limitations of the implementation.
95-
5. Add a short section to the bottom of *doc/listeners.rst*.
96-
6. Add tests where appropriate, for example by simply adding a test case called
96+
6. Add a short section to the bottom of *doc/listeners.rst*.
97+
7. Add tests where appropriate, for example by simply adding a test case called
9798
`class TestCanstoreFileFormat(ReaderWriterTest)` to *test/logformats_test.py*.
9899
That should already handle all of the general testing.
99100
Just follow the way the other tests in there do it.
100-
7. Add imports to *can/__init__py* and *can/io/__init__py* so that the
101+
8. Add imports to *can/__init__py* and *can/io/__init__py* so that the
101102
new classes can be simply imported as *from can import CanstoreReader, CanstoreWriter*.
102103

103104

0 commit comments

Comments
 (0)