feat(driverbuilder): add autoDriverDownload() to FirefoxDriverBuilder

acdcjunior · acdcjunior · commit d43248ded69e · 2017-12-03T17:02:19.000-02:00
diff --git a/src/main/java/io/github/seleniumquery/browser/driver/builders/FirefoxDriverBuilder.java b/src/main/java/io/github/seleniumquery/browser/driver/builders/FirefoxDriverBuilder.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015 seleniumQuery authors
+ * Copyright (c) 2017 seleniumQuery authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
 import io.github.seleniumquery.browser.driver.DriverBuilder;
 import org.openqa.selenium.Keys;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.chrome.ChromeDriver;
 import org.openqa.selenium.firefox.FirefoxDriver;
 import org.openqa.selenium.firefox.FirefoxProfile;
 import org.openqa.selenium.interactions.Actions;
@@ -63,6 +64,7 @@ public FirefoxDriverBuilder withProfile(FirefoxProfile firefoxProfile) {
 
     @Override
     protected WebDriver build() {
+        autoDownloadDriverIfAskedFor(FirefoxDriver.class);
         DesiredCapabilities capabilities = createConfiguredCapabilities();
         FirefoxDriver firefoxDriver = new FirefoxDriver(capabilities);
         disableJavaScriptIfWanted(firefoxDriver);
@@ -100,4 +102,4 @@ private void disableJavaScript(FirefoxDriver driver) {
         driver.get("about:blank");
     }
 
-}
+}
diff --git a/src/test/java/endtoend/browser/driver/builders/FirefoxDriverBuilderTest.java b/src/test/java/endtoend/browser/driver/builders/FirefoxDriverBuilderTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015 seleniumQuery authors
+ * Copyright (c) 2017 seleniumQuery authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -35,7 +35,8 @@ public class FirefoxDriverBuilderTest {
 
     @Before
     public void setUp() {
-        assumeTrue(SetUpAndTearDownDriver.driverToRunTestsIn.canRunFirefox());
+        assumeTrue("To run the tests in this class, EndToEndTestConfig#whatDriversShouldTestsRun() should return Firefox.",
+            SetUpAndTearDownDriver.driverToRunTestsIn.canRunFirefox());
     }
 
     @After
@@ -84,4 +85,13 @@ public static void assertJavaScriptIsOff(WebDriver driver) {
         assertThat(driver.findElements(By.tagName("div")), hasSize(1));
     }
 
-}
+    @Test
+    public void autoDriverDownload() {
+        // given
+        // when
+        $.driver().useFirefox().autoDriverDownload();
+        // then
+        assertJavaScriptIsOn($.driver().get());
+    }
+
+}
