Merge pull request #45 from sede-open/release/release-2024-01-15-pk

PeterDKay · web-flow · commit 0395eb3a748e · 2024-01-15T17:54:23.000Z
Release/release 2024 01 15 pk
diff --git a/src/databricks/sqlalchemy/dialect/base.py b/src/databricks/sqlalchemy/dialect/base.py
@@ -101,6 +101,8 @@ def visit_create_table(self, create, **kw):
                 processed = self.process(
                     create_column, first_pk=column.primary_key and not first_pk
                 )
+                if column.autoincrement is True:   # If doesn't work try 'is True' and == 'True'
+                    processed = "`".join(processed.split("`")[:-1]) + "` " + "BIGINT GENERATED ALWAYS AS IDENTITY"
                 if processed is not None:
                     text += separator
                     separator = ", \n"
diff --git a/src/databricks/sqlalchemy/dialect/compiler.py b/src/databricks/sqlalchemy/dialect/compiler.py
@@ -7,6 +7,9 @@ class DatabricksTypeCompiler(compiler.GenericTypeCompiler):
     def visit_INTEGER(self, type_):
         return "INT"
 
+    def visit_BIGINT(self, type_):
+        return "BIGINT"
+
     def visit_NUMERIC(self, type_):
         if type_.precision is None:
             return "DECIMAL"

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,8 @@ def visit_create_table(self, create, **kw):`
`101`	`101`	`processed = self.process(`
`102`	`102`	`create_column, first_pk=column.primary_key and not first_pk`
`103`	`103`	`)`
	`104`	`+ if column.autoincrement is True: # If doesn't work try 'is True' and == 'True'`
	`105`	+ processed = "`".join(processed.split("`")[:-1]) + "` " + "BIGINT GENERATED ALWAYS AS IDENTITY"
`104`	`106`	`if processed is not None:`
`105`	`107`	`text += separator`
`106`	`108`	`separator = ", \n"`