github bcgit#499 tweak to RSA exception test

dghgit · dghgit · commit ec381a13ad20 · 2019-04-24T09:08:32.000+10:00
diff --git a/core/src/main/java/org/bouncycastle/crypto/params/RSAKeyParameters.java b/core/src/main/java/org/bouncycastle/crypto/params/RSAKeyParameters.java
@@ -41,18 +41,18 @@ public RSAKeyParameters(
 
     private BigInteger validate(BigInteger modulus)
     {
+        if ((modulus.intValue() & 1) == 0)
+        {
+            throw new IllegalArgumentException("RSA modulus is even");
+        }
+
         // If you need to set this you need to have a serious word to whoever is generating
         // your keys.
         if (Properties.isOverrideSet("org.bouncycastle.rsa.allow_unsafe_mod"))
         {
             return modulus;
         }
 
-        if ((modulus.intValue() & 1) == 0)
-        {
-            throw new IllegalArgumentException("RSA modulus is even");
-        }
-
         if (!modulus.gcd(SMALL_PRIMES_PRODUCT).equals(ONE))
         {
             throw new IllegalArgumentException("RSA modulus has a small prime factor");

Original file line number	Diff line number	Diff line change
`@@ -41,18 +41,18 @@ public RSAKeyParameters(`
`41`	`41`
`42`	`42`	`private BigInteger validate(BigInteger modulus)`
`43`	`43`	`{`
	`44`	`+ if ((modulus.intValue() & 1) == 0)`
	`45`	`+ {`
	`46`	`+ throw new IllegalArgumentException("RSA modulus is even");`
	`47`	`+ }`
	`48`	`+`
`44`	`49`	`// If you need to set this you need to have a serious word to whoever is generating`
`45`	`50`	`// your keys.`
`46`	`51`	`if (Properties.isOverrideSet("org.bouncycastle.rsa.allow_unsafe_mod"))`
`47`	`52`	`{`
`48`	`53`	`return modulus;`
`49`	`54`	`}`
`50`	`55`
`51`		`- if ((modulus.intValue() & 1) == 0)`
`52`		`- {`
`53`		`- throw new IllegalArgumentException("RSA modulus is even");`
`54`		`- }`
`55`		`-`
`56`	`56`	`if (!modulus.gcd(SMALL_PRIMES_PRODUCT).equals(ONE))`
`57`	`57`	`{`
`58`	`58`	`throw new IllegalArgumentException("RSA modulus has a small prime factor");`