it will terminate early if expected.length != supplied.length

ZZMarquis · web-flow · commit ca4dd78cb849 · 2019-04-18T17:54:03.000+08:00
diff --git a/core/src/main/java/org/bouncycastle/util/Arrays.java b/core/src/main/java/org/bouncycastle/util/Arrays.java
@@ -156,11 +156,6 @@ public static boolean constantTimeAreEqual(
         byte[]  expected,
         byte[]  supplied)
     {
-        if (expected == supplied)
-        {
-            return true;
-        }
-
         if (expected == null || supplied == null)
         {
             return false;

Original file line number	Diff line number	Diff line change
`@@ -156,11 +156,6 @@ public static boolean constantTimeAreEqual(`
`156`	`156`	`byte[] expected,`
`157`	`157`	`byte[] supplied)`
`158`	`158`	`{`
`159`		`- if (expected == supplied)`
`160`		`- {`
`161`		`- return true;`
`162`		`- }`
`163`		`-`
`164`	`159`	`if (expected == null \|\| supplied == null)`
`165`	`160`	`{`
`166`	`161`	`return false;`