From c748310f15e41509fde80caeabc4f292253e675e Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 12:12:09 +0100 Subject: [PATCH 1/9] SCB bot now makes sure the release and local version have same format i.e v1.0 or 1.0 Added on push trigger for testing Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 177 +++++++++++++++++---------------- 1 file changed, 94 insertions(+), 83 deletions(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index c5fd2543b5..8c94c38f40 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -1,5 +1,6 @@ name: Check outdated scanners on: + push: schedule: - cron: "15 9 * * *" # Daily at 9:15 (avoids the beginning of the hour congestion) jobs: @@ -36,94 +37,104 @@ jobs: git-user-signingkey: true git-commit-gpgsign: true - - name: Fetch scanner's version API - uses: mikefarah/yq@v4.4.1 - with: - cmd: echo versionApi=$(yq e .annotations.versionApi scanners/${{ matrix.scanner }}/Chart.yaml) >> $GITHUB_ENV - - - name: Fetch latest release scanner version - run: echo release=$((curl -sL ${{env.versionApi}} ) | jq -r ".tag_name") | tr -d "v" >> $GITHUB_ENV - - name: Fetch local scanner version uses: mikefarah/yq@v4.4.1 with: - cmd: echo local=$(yq e .appVersion scanners/${{ matrix.scanner }}/Chart.yaml) | tr -d "v" >> $GITHUB_ENV + cmd: echo local=$(yq e .appVersion scanners/${{ matrix.scanner }}/Chart.yaml) >> $GITHUB_ENV - - name: Check if scanner is outdated and if PR already exists - if: ${{ env.release != env.local }} - run: | - echo 'The ${{ matrix.scanner }} scanner is outdated. Current SCB version is ${{env.local}} and remote version is ${{env.release}}' - - pullRequestTitle="[SCB-Bot] Upgraded ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" - echo pullRequest=$pullRequestTitle >> $GITHUB_ENV - - echo ${{ secrets.GITHUB_TOKEN }} | gh auth login --with-token - echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV - - - name: Fetch new release changelog - if: ${{ env.release != env.local }} - run: echo releaseChangelog=$((curl -sL ${{env.versionApi}} ) | jq -r ".body") >> $GITHUB_ENV - - - name: Upgrade Scanner Helm Chart - if: ${{ env.release != env.local && env.prExists == 0 }} + - name: Fetch scanner's version API uses: mikefarah/yq@v4.4.1 with: - # appVersion value in chart is replaced with release value. Empty lines are deleted in the process - cmd: yq e --inplace '.appVersion = "v${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml - - # Updating Helm Docs - - name: Download Helm Docs - run: | - mkdir helm-docs - cd helm-docs - - curl --output helm-docs.tar.gz --location https://github.com/norwoodj/helm-docs/releases/download/v1.5.0/helm-docs_1.5.0_Linux_x86_64.tar.gz - # Checksum must be extracted from the checksum file every time helm-docs gets updated. - echo "a352e13a8438045b8ed138b821cb757c177acd999c1af77345152d7a64b0ddb7 helm-docs.tar.gz" | shasum --check - - tar -xvf helm-docs.tar.gz - # Verify installation - ./helm-docs --version - - sudo mv helm-docs /usr/local/bin/helm-docs - - - name: Generate README - run: | - make readme - - name: Generate Demo-Apps Docs - run: make demo-apps-docs - - - name: Generate Hooks Docs - run: make hook-docs - - - name: Generate Scanner Docs - run: make scanner-docs - - - name: Generate Operator Docs - run: make operator-docs - - - name: Generate AutoDiscovery Docs - run: make auto-discovery-docs + cmd: echo versionApi=$(yq e .annotations.versionApi scanners/${{ matrix.scanner }}/Chart.yaml) >> $GITHUB_ENV - - name: Remove Helm Docs Files + - name: Fetch latest release scanner version run: | - # Remove helm-docs download to ensure they don't get committed back - rm -rf helm-docs - - - name: Create Pull Request - if: ${{ env.release != env.local && env.prExists == 0 }} - uses: peter-evans/create-pull-request@v3 - with: - token: ${{ secrets.SCB_BOT_USER_TOKEN }} - committer: secureCodeBoxBot - author: secureCodeBoxBot - title: ${{ env.pullRequest }} - body: "This is an automated Pull Request by the SCB-Bot. It upgrades ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" - branch: "dependencies/upgrading-${{ matrix.scanner }}-to-${{env.release}}" - labels: dependencies,scanner - commit-message: | - Upgrading ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}} - ## Release changes : - ${{env.releaseChangelog}} - signoff: true - base: main + release=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name") + if [[ ${env.local:0:1} != ${release:0:1} ]] ; then + if [[ ${env.local:0:1} == "v" ]] ; then + upgrade=v${release}; + elif [[ ${release:0:1} == "v" ]] ; then + upgrade=$(echo $release| tr -d "v") + fi + fi + echo $upgrade + echo release=$upgrade >> $GITHUB_ENV + + # - name: Check if scanner is outdated and if PR already exists + # if: ${{ env.release != env.local }} + # run: | + # echo 'The ${{ matrix.scanner }} scanner is outdated. Current SCB version is ${{env.local}} and remote version is ${{env.release}}' + + # pullRequestTitle="[SCB-Bot] Upgraded ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" + # echo pullRequest=$pullRequestTitle >> $GITHUB_ENV + + # echo ${{ secrets.GITHUB_TOKEN }} | gh auth login --with-token + # echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV + + # - name: Fetch new release changelog + # if: ${{ env.release != env.local }} + # run: echo releaseChangelog=$((curl -sL ${{env.versionApi}} ) | jq -r ".body") >> $GITHUB_ENV + + # - name: Upgrade Scanner Helm Chart + # if: ${{ env.release != env.local && env.prExists == 0 }} + # uses: mikefarah/yq@v4.4.1 + # with: + # # appVersion value in chart is replaced with release value. Empty lines are deleted in the process + # cmd: yq e --inplace '.appVersion = "v${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml + + # # Updating Helm Docs + # - name: Download Helm Docs + # run: | + # mkdir helm-docs + # cd helm-docs + + # curl --output helm-docs.tar.gz --location https://github.com/norwoodj/helm-docs/releases/download/v1.5.0/helm-docs_1.5.0_Linux_x86_64.tar.gz + # # Checksum must be extracted from the checksum file every time helm-docs gets updated. + # echo "a352e13a8438045b8ed138b821cb757c177acd999c1af77345152d7a64b0ddb7 helm-docs.tar.gz" | shasum --check + + # tar -xvf helm-docs.tar.gz + # # Verify installation + # ./helm-docs --version + + # sudo mv helm-docs /usr/local/bin/helm-docs + + # - name: Generate README + # run: | + # make readme + # - name: Generate Demo-Apps Docs + # run: make demo-apps-docs + + # - name: Generate Hooks Docs + # run: make hook-docs + + # - name: Generate Scanner Docs + # run: make scanner-docs + + # - name: Generate Operator Docs + # run: make operator-docs + + # - name: Generate AutoDiscovery Docs + # run: make auto-discovery-docs + + # - name: Remove Helm Docs Files + # run: | + # # Remove helm-docs download to ensure they don't get committed back + # rm -rf helm-docs + + # - name: Create Pull Request + # if: ${{ env.release != env.local && env.prExists == 0 }} + # uses: peter-evans/create-pull-request@v3 + # with: + # token: ${{ secrets.SCB_BOT_USER_TOKEN }} + # committer: secureCodeBoxBot + # author: secureCodeBoxBot + # title: ${{ env.pullRequest }} + # body: "This is an automated Pull Request by the SCB-Bot. It upgrades ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" + # branch: "dependencies/upgrading-${{ matrix.scanner }}-to-${{env.release}}" + # labels: dependencies,scanner + # commit-message: | + # Upgrading ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}} + # ## Release changes : + # ${{env.releaseChangelog}} + # signoff: true + # base: main From e5ce1c7ad586b3c070cd64d91460142b762a205e Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 12:17:20 +0100 Subject: [PATCH 2/9] fixed wrong variable formatting Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index 8c94c38f40..bbe89e8145 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -49,9 +49,9 @@ jobs: - name: Fetch latest release scanner version run: | - release=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name") - if [[ ${env.local:0:1} != ${release:0:1} ]] ; then - if [[ ${env.local:0:1} == "v" ]] ; then + local=${{env.local}} + if [[ ${local:0:1} != ${release:0:1} ]] ; then + if [[ ${local:0:1} == "v" ]] ; then upgrade=v${release}; elif [[ ${release:0:1} == "v" ]] ; then upgrade=$(echo $release| tr -d "v") From be8e7d39db8028493b8e01f3f018e6272837916f Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 12:22:18 +0100 Subject: [PATCH 3/9] intializes remote release version variable in scb-bot Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index bbe89e8145..d737b592a8 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -49,6 +49,7 @@ jobs: - name: Fetch latest release scanner version run: | + release=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name" ) local=${{env.local}} if [[ ${local:0:1} != ${release:0:1} ]] ; then if [[ ${local:0:1} == "v" ]] ; then From 44ea30d5970ecf1aa24d2ea9183b5e4abff86339 Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 12:29:55 +0100 Subject: [PATCH 4/9] fix empty variable for matching scanner versions Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index d737b592a8..37af0065b5 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -48,8 +48,10 @@ jobs: cmd: echo versionApi=$(yq e .annotations.versionApi scanners/${{ matrix.scanner }}/Chart.yaml) >> $GITHUB_ENV - name: Fetch latest release scanner version + # A hacky way to solve the problem where the docker image is in the "1.0" format and the github release is in the "v1.0" format + # We make sure to add or remove the "v" character when necessary run: | - release=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name" ) + upgrade=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name" ) local=${{env.local}} if [[ ${local:0:1} != ${release:0:1} ]] ; then if [[ ${local:0:1} == "v" ]] ; then @@ -61,16 +63,16 @@ jobs: echo $upgrade echo release=$upgrade >> $GITHUB_ENV - # - name: Check if scanner is outdated and if PR already exists - # if: ${{ env.release != env.local }} - # run: | - # echo 'The ${{ matrix.scanner }} scanner is outdated. Current SCB version is ${{env.local}} and remote version is ${{env.release}}' + - name: Check if scanner is outdated and if PR already exists + if: ${{ env.release != env.local }} + run: | + echo 'The ${{ matrix.scanner }} scanner is outdated. Current SCB version is ${{env.local}} and remote version is ${{env.release}}' - # pullRequestTitle="[SCB-Bot] Upgraded ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" - # echo pullRequest=$pullRequestTitle >> $GITHUB_ENV + pullRequestTitle="[SCB-Bot] Upgraded ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" + echo pullRequest=$pullRequestTitle >> $GITHUB_ENV - # echo ${{ secrets.GITHUB_TOKEN }} | gh auth login --with-token - # echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV + echo ${{ secrets.GITHUB_TOKEN }} | gh auth login --with-token + echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV # - name: Fetch new release changelog # if: ${{ env.release != env.local }} From 83a361504c6074f3af2e894164399029d4523cd1 Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 12:37:25 +0100 Subject: [PATCH 5/9] fixes missing variable Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index 37af0065b5..805937bcbb 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -51,8 +51,10 @@ jobs: # A hacky way to solve the problem where the docker image is in the "1.0" format and the github release is in the "v1.0" format # We make sure to add or remove the "v" character when necessary run: | - upgrade=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name" ) local=${{env.local}} + release=$(curl -sL ${{env.versionApi}} | jq -r ".tag_name" ) + upgrade=$release + if [[ ${local:0:1} != ${release:0:1} ]] ; then if [[ ${local:0:1} == "v" ]] ; then upgrade=v${release}; @@ -60,6 +62,7 @@ jobs: upgrade=$(echo $release| tr -d "v") fi fi + echo $upgrade echo release=$upgrade >> $GITHUB_ENV From 51ea91a9bb9ae909102fc429639b0cdf4c48d787 Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 15:47:53 +0100 Subject: [PATCH 6/9] restored the commented out section in the scb bot workflow Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 134 ++++++++++++++++----------------- 1 file changed, 67 insertions(+), 67 deletions(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index 805937bcbb..e1940136ba 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -77,70 +77,70 @@ jobs: echo ${{ secrets.GITHUB_TOKEN }} | gh auth login --with-token echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV - # - name: Fetch new release changelog - # if: ${{ env.release != env.local }} - # run: echo releaseChangelog=$((curl -sL ${{env.versionApi}} ) | jq -r ".body") >> $GITHUB_ENV - - # - name: Upgrade Scanner Helm Chart - # if: ${{ env.release != env.local && env.prExists == 0 }} - # uses: mikefarah/yq@v4.4.1 - # with: - # # appVersion value in chart is replaced with release value. Empty lines are deleted in the process - # cmd: yq e --inplace '.appVersion = "v${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml - - # # Updating Helm Docs - # - name: Download Helm Docs - # run: | - # mkdir helm-docs - # cd helm-docs - - # curl --output helm-docs.tar.gz --location https://github.com/norwoodj/helm-docs/releases/download/v1.5.0/helm-docs_1.5.0_Linux_x86_64.tar.gz - # # Checksum must be extracted from the checksum file every time helm-docs gets updated. - # echo "a352e13a8438045b8ed138b821cb757c177acd999c1af77345152d7a64b0ddb7 helm-docs.tar.gz" | shasum --check - - # tar -xvf helm-docs.tar.gz - # # Verify installation - # ./helm-docs --version - - # sudo mv helm-docs /usr/local/bin/helm-docs - - # - name: Generate README - # run: | - # make readme - # - name: Generate Demo-Apps Docs - # run: make demo-apps-docs - - # - name: Generate Hooks Docs - # run: make hook-docs - - # - name: Generate Scanner Docs - # run: make scanner-docs - - # - name: Generate Operator Docs - # run: make operator-docs - - # - name: Generate AutoDiscovery Docs - # run: make auto-discovery-docs - - # - name: Remove Helm Docs Files - # run: | - # # Remove helm-docs download to ensure they don't get committed back - # rm -rf helm-docs - - # - name: Create Pull Request - # if: ${{ env.release != env.local && env.prExists == 0 }} - # uses: peter-evans/create-pull-request@v3 - # with: - # token: ${{ secrets.SCB_BOT_USER_TOKEN }} - # committer: secureCodeBoxBot - # author: secureCodeBoxBot - # title: ${{ env.pullRequest }} - # body: "This is an automated Pull Request by the SCB-Bot. It upgrades ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" - # branch: "dependencies/upgrading-${{ matrix.scanner }}-to-${{env.release}}" - # labels: dependencies,scanner - # commit-message: | - # Upgrading ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}} - # ## Release changes : - # ${{env.releaseChangelog}} - # signoff: true - # base: main + - name: Fetch new release changelog + if: ${{ env.release != env.local }} + run: echo releaseChangelog=$((curl -sL ${{env.versionApi}} ) | jq -r ".body") >> $GITHUB_ENV + + - name: Upgrade Scanner Helm Chart + if: ${{ env.release != env.local && env.prExists == 0 }} + uses: mikefarah/yq@v4.4.1 + with: + # appVersion value in chart is replaced with release value. Empty lines are deleted in the process + cmd: yq e --inplace '.appVersion = "v${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml + + # Updating Helm Docs + - name: Download Helm Docs + run: | + mkdir helm-docs + cd helm-docs + + curl --output helm-docs.tar.gz --location https://github.com/norwoodj/helm-docs/releases/download/v1.5.0/helm-docs_1.5.0_Linux_x86_64.tar.gz + # Checksum must be extracted from the checksum file every time helm-docs gets updated. + echo "a352e13a8438045b8ed138b821cb757c177acd999c1af77345152d7a64b0ddb7 helm-docs.tar.gz" | shasum --check + + tar -xvf helm-docs.tar.gz + # Verify installation + ./helm-docs --version + + sudo mv helm-docs /usr/local/bin/helm-docs + + - name: Generate README + run: | + make readme + - name: Generate Demo-Apps Docs + run: make demo-apps-docs + + - name: Generate Hooks Docs + run: make hook-docs + + - name: Generate Scanner Docs + run: make scanner-docs + + - name: Generate Operator Docs + run: make operator-docs + + - name: Generate AutoDiscovery Docs + run: make auto-discovery-docs + + - name: Remove Helm Docs Files + run: | + # Remove helm-docs download to ensure they don't get committed back + rm -rf helm-docs + + - name: Create Pull Request + if: ${{ env.release != env.local && env.prExists == 0 }} + uses: peter-evans/create-pull-request@v3 + with: + token: ${{ secrets.SCB_BOT_USER_TOKEN }} + committer: secureCodeBoxBot + author: secureCodeBoxBot + title: ${{ env.pullRequest }} + body: "This is an automated Pull Request by the SCB-Bot. It upgrades ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}}" + branch: "dependencies/upgrading-${{ matrix.scanner }}-to-${{env.release}}" + labels: dependencies,scanner + commit-message: | + Upgrading ${{ matrix.scanner }} from ${{env.local}} to ${{env.release}} + ## Release changes : + ${{env.releaseChangelog}} + signoff: true + base: main From 89d12c860e7d148533ff21deddf9179459ad9e6a Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 15:51:45 +0100 Subject: [PATCH 7/9] removed redundant v character in upgrade step Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index e1940136ba..87d874e7b8 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -86,7 +86,7 @@ jobs: uses: mikefarah/yq@v4.4.1 with: # appVersion value in chart is replaced with release value. Empty lines are deleted in the process - cmd: yq e --inplace '.appVersion = "v${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml + cmd: yq e --inplace '.appVersion = "${{env.release}}"' ./scanners/${{ matrix.scanner }}/Chart.yaml # Updating Helm Docs - name: Download Helm Docs From 80b710d2668e4c0514714a096575c99b876d20c9 Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 16:01:26 +0100 Subject: [PATCH 8/9] Added checking if release version is null this avoids issues that occur when curl request fails Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index 87d874e7b8..91016d510f 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -67,7 +67,7 @@ jobs: echo release=$upgrade >> $GITHUB_ENV - name: Check if scanner is outdated and if PR already exists - if: ${{ env.release != env.local }} + if: ${{ env.release != env.local && env.release != null }} run: | echo 'The ${{ matrix.scanner }} scanner is outdated. Current SCB version is ${{env.local}} and remote version is ${{env.release}}' @@ -78,11 +78,11 @@ jobs: echo prExists=$(gh pr list --state open --limit 100 | grep -F "$pullRequestTitle" -c) >> $GITHUB_ENV - name: Fetch new release changelog - if: ${{ env.release != env.local }} + if: ${{ env.release != env.local && env.release != null }} run: echo releaseChangelog=$((curl -sL ${{env.versionApi}} ) | jq -r ".body") >> $GITHUB_ENV - name: Upgrade Scanner Helm Chart - if: ${{ env.release != env.local && env.prExists == 0 }} + if: ${{ env.release != env.local && env.prExists == 0 && env.release != null}} uses: mikefarah/yq@v4.4.1 with: # appVersion value in chart is replaced with release value. Empty lines are deleted in the process @@ -128,7 +128,7 @@ jobs: rm -rf helm-docs - name: Create Pull Request - if: ${{ env.release != env.local && env.prExists == 0 }} + if: ${{ env.release != env.local && env.prExists == 0 && env.release != null }} uses: peter-evans/create-pull-request@v3 with: token: ${{ secrets.SCB_BOT_USER_TOKEN }} From eef02f12bae5655dcefbd8f7effddf588e85914b Mon Sep 17 00:00:00 2001 From: Ilyes Ben Dlala Date: Tue, 16 Nov 2021 16:31:07 +0100 Subject: [PATCH 9/9] removed on push trigger for scb-bot Signed-off-by: Ilyes Ben Dlala --- .github/workflows/scb-bot.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/scb-bot.yaml b/.github/workflows/scb-bot.yaml index 91016d510f..531b6e601e 100644 --- a/.github/workflows/scb-bot.yaml +++ b/.github/workflows/scb-bot.yaml @@ -1,6 +1,5 @@ name: Check outdated scanners on: - push: schedule: - cron: "15 9 * * *" # Daily at 9:15 (avoids the beginning of the hour congestion) jobs: