Currently, scanner integration tests have a global command to be launched, defined in scanners.mk - but all scanners that actually use integration tests overwrite the command in their own Makefiles. The command from the global Makefile does not work for scanners (it uses incorrect paths), so any scanner that does not overwrite it in its own Makefile will not have working integration tests (this was the case for Gitleaks until the changes introduced in #830).
Does someone know why this is the case, and if there is any reason not to just replace the global command with the ones that are used by the scanners? The structure of the global integration tests matches the layout actually used for the hooks (as in: where are the integration test definitions placed?), so is this a case of an incomplete refactoring?
Currently, scanner integration tests have a global command to be launched, defined in scanners.mk - but all scanners that actually use integration tests overwrite the command in their own Makefiles. The command from the global Makefile does not work for scanners (it uses incorrect paths), so any scanner that does not overwrite it in its own Makefile will not have working integration tests (this was the case for Gitleaks until the changes introduced in #830).
Does someone know why this is the case, and if there is any reason not to just replace the global command with the ones that are used by the scanners? The structure of the global integration tests matches the layout actually used for the hooks (as in: where are the integration test definitions placed?), so is this a case of an incomplete refactoring?