Move param to a named param in a object

J12934 · J12934 · commit aaf3b066b7a9 · 2026-02-10T10:03:52.000+01:00
Makes it easier to understand what this bool flag is doing from the tests

Signed-off-by: Jannik Hollenbach &lt;jannik.hollenbach@iteratec.com&gt;
diff --git a/scanners/subfinder/parser/parser.js b/scanners/subfinder/parser/parser.js
@@ -7,9 +7,11 @@ const DOMAIN_FLAGS = ["-d", "-domain", "--domain"];
 export async function parse(
   fileContent,
   scan,
-  includeTargetDomain = process.env["INCLUDE_TARGET_DOMAIN"]?.toLowerCase() ==
-    "true",
+  options = {},
 ) {
+  const includeTargetDomain = options.includeTargetDomain ??
+    (process.env["INCLUDE_TARGET_DOMAIN"]?.toLowerCase() === "true");
+
   const targets = parseResultFile(fileContent);
   const findings = transformToFindings(targets);
 
diff --git a/scanners/subfinder/parser/parser.test.js b/scanners/subfinder/parser/parser.test.js
@@ -59,7 +59,7 @@ test("should properly parse empty json file with includeTargetDomain=true", asyn
   const fileContent = await readFile(__dirname + "/__testFiles__/empty.jsonl", {
     encoding: "utf8",
   });
-  const findings = await parse(fileContent, scan, "true");
+  const findings = await parse(fileContent, scan, { includeTargetDomain: true });
   // validate findings
   expect(validateParser(findings)).toBeUndefined();
   expect(findings).toMatchSnapshot();
@@ -85,7 +85,7 @@ test("should properly parse subfinder json file and add target domain to finding
       encoding: "utf8",
     },
   );
-  const findings = await parse(fileContent, scan, "true");
+  const findings = await parse(fileContent, scan, { includeTargetDomain: true });
   // validate findings
   expect(validateParser(findings)).toBeUndefined();
   expect(findings).toMatchSnapshot();
@@ -111,7 +111,7 @@ test("should properly parse subfinder json file and add target domain to finding
       encoding: "utf8",
     },
   );
-  const findings = await parse(fileContent, scan, "true");
+  const findings = await parse(fileContent, scan, { includeTargetDomain: true });
   // validate findings
   expect(validateParser(findings)).toBeUndefined();
   expect(findings).toMatchSnapshot();
@@ -137,7 +137,7 @@ test("should properly parse subfinder json file and add target domain to finding
       encoding: "utf8",
     },
   );
-  const findings = await parse(fileContent, scan, "true");
+  const findings = await parse(fileContent, scan, { includeTargetDomain: true });
   // validate findings
   expect(validateParser(findings)).toBeUndefined();
   expect(findings).toMatchSnapshot();
