feat: update scan command to receive parameters

Freedisch · Freedisch · commit a5c69e37fbac · 2024-06-17T01:34:45.000+02:00
Signed-off-by: freedisch &lt;freeproduc@gmail.com&gt;
diff --git a/scbctl/cmd/scans.go b/scbctl/cmd/scans.go
@@ -7,6 +7,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 
 	v1 "github.com/secureCodeBox/secureCodeBox/operator/apis/execution/v1"
 	kubernetes "github.com/secureCodeBox/secureCodeBox/scbctl/pkg"
@@ -43,16 +44,27 @@ var ScanCmd = &cobra.Command{
 		}
 
 		scanName := args[0]
-		target := args[1]
+		paramIndex := cmd.ArgsLenAtDash()
+		if paramIndex == -1 {
+			return errors.New("You must use '--' to separate scan parameters")
+		}
+
 
+		parameters := args[paramIndex:]
+		
+	
 		fmt.Println("🎬 Initializing Kubernetes client")
 
 		kubeclient, namespace, err := clientProvider.GetClient(kubeconfigArgs)
 		if err != nil {
 			return fmt.Errorf("Error initializing Kubernetes client: %s", err)
 		}
 
-		fmt.Printf("🆕 Creating a new scan with name '%s' and target '%s'\n", scanName, target)
+		if namespaceFlag, err := cmd.Flags().GetString("namespace"); err == nil && namespaceFlag != "" {
+			namespace = namespaceFlag
+		}
+
+		fmt.Printf("🆕 Creating a new scan with name '%s' and target '%s'\n", scanName, strings.Join(parameters, " "))
 
 		scan := &v1.Scan{
 			TypeMeta: metav1.TypeMeta{
@@ -65,9 +77,7 @@ var ScanCmd = &cobra.Command{
 			},
 			Spec: v1.ScanSpec{
 				ScanType: scanName,
-				Parameters: []string{
-					target,
-				},
+				Parameters: parameters,
 			},
 		}
 
diff --git a/scbctl/main.go b/scbctl/main.go
@@ -26,8 +26,6 @@ var rootCmd = &cobra.Command{
 func init() {
 	utilruntime.Must(v1.AddToScheme(scheme))
 	rootCmd.AddCommand(cmd.ScanCmd)
-	rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
-
 	kubeconfigArgs.AddFlags(rootCmd.PersistentFlags())
 }
 func main() {

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@ var rootCmd = &cobra.Command{`
`26`	`26`	`func init() {`
`27`	`27`	`utilruntime.Must(v1.AddToScheme(scheme))`
`28`	`28`	`rootCmd.AddCommand(cmd.ScanCmd)`
`29`		`- rootCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")`
`30`		`-`
`31`	`29`	`kubeconfigArgs.AddFlags(rootCmd.PersistentFlags())`
`32`	`30`	`}`
`33`	`31`	`func main() {`