Fix test of error handling in scanner helpers

Ilyesbdlala · J12934 · commit 679d07da1da2 · 2024-02-07T12:27:58.000+01:00
This is because the test would pass when there is not exception thrown. ref: https://jestjs.io/docs/expect#rejects Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com> Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
diff --git a/scanners/helpers.test.js b/scanners/helpers.test.js
@@ -85,22 +85,17 @@ describe("Kubernetes interaction tests", () => {
 
       const k8sApi = { k8sCRDApi:mockK8sCRDApi, k8sBatchApi:mockK8sBatchApi, k8sPodsApi:mockPodsApi }
 
-      try {
-        await scan(
-          "typo3scan-old-typo3",
-          "typo3scan",
-          [],
-          180,
-          [],
-          [],
-          [],
-          k8sApi
-        );
-      } catch (error) {
-        expect(error).toMatchInlineSnapshot(
-          `[Error: Scan failed with description "Mocked Error"]`
-        );
-      }
+      return expect(scan(
+        "typo3scan-old-typo3",
+        "typo3scan",
+        [],
+        180,
+        [],
+        [],
+        [],
+        k8sApi
+      )).rejects.toThrow('Scan failed with description "Mocked Error"');
+      
     });
   });
 
@@ -167,26 +162,20 @@ describe("Kubernetes interaction tests", () => {
       );
       const k8sApi = { k8sCRDApi:mockK8sCRDApi, k8sBatchApi:mockK8sBatchApi, k8sPodsApi:mockPodsApi }
 
-      try {
-        await cascadingScan(
-          "nmap-dummy-ssh",
-          "nmap",
-          ["-Pn", "-sV", "dummy-ssh.demo-targets.svc"],
-          {
-            nameCascade: "ncrack-ssh",
-            matchLabels: {
-              "securecodebox.io/invasive": "invasive",
-              "securecodebox.io/intensive": "high",
-            },
+      return expect(cascadingScan(
+        "nmap-dummy-ssh",
+        "nmap",
+        ["-Pn", "-sV", "dummy-ssh.demo-targets.svc"],
+        {
+          nameCascade: "ncrack-ssh",
+          matchLabels: {
+            "securecodebox.io/invasive": "invasive",
+            "securecodebox.io/intensive": "high",
           },
-          180,
-          k8sApi
-        );
-      } catch (error) {
-        expect(error).toMatchInlineSnapshot(
-          `[Error: Initial Scan failed with description "Mocked Error"]`
-        );
-      }
+        },
+        180,
+        k8sApi
+      )).rejects.toThrow('Initial Scan failed with description "Mocked Error"'); 
     });
   });
 });
