Skip to content

Commit 33d1369

Browse files
J12934J12934
committed
Remove deprecated kubeaudit scanner
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
1 parent 1ecc084 commit 33d1369

47 files changed

Lines changed: 14 additions & 1874 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/ci.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,6 @@ jobs:
424424
- ffuf
425425
- git-repo-scanner
426426
- gitleaks
427-
- kubeaudit
428427
- kube-hunter
429428
- ncrack
430429
- nikto

‎.github/workflows/release-build.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ jobs:
329329
- git-repo-scanner
330330
- gitleaks
331331
- kube-hunter
332-
- kubeaudit
333332
- ncrack
334333
- nikto
335334
- nmap
@@ -415,7 +414,6 @@ jobs:
415414
- cmseek
416415
- ffuf
417416
- kube-hunter
418-
- kubeaudit
419417
- ncrack
420418
- nmap
421419
- nikto

‎.github/workflows/scb-bot.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ jobs:
3333
- ffuf
3434
- gitleaks
3535
- kube-hunter
36-
- kubeaudit
3736
- ncrack
3837
- nuclei
3938
- semgrep

‎bin/release-note-grouper.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ Example Usage: `pbpaste | release-version-grouper.js`
1313
1414
E.g. turn this:
1515
```md
16-
[SCB-Bot] Upgraded kubeaudit from 0.22.0 to 0.22.1 @secureCodeBoxBot (#2111)
1716
[SCB-Bot] Upgraded semgrep from 1.50.0 to 1.51.0 @secureCodeBoxBot (#2112)
1817
[SCB-Bot] Upgraded nuclei from v3.0.4 to v3.1.0 @secureCodeBoxBot (#2114)
1918
[SCB-Bot] Upgraded gitleaks from v8.18.0 to v8.18.1 @secureCodeBoxBot (#2103)
@@ -23,7 +22,6 @@ E.g. turn this:
2322
into this:
2423
```md
2524
- Upgraded gitleaks from v8.18.0 to v8.18.1 @secureCodeBoxBot (#2103)
26-
- Upgraded kubeaudit from 0.22.0 to 0.22.1 @secureCodeBoxBot (#2111)
2725
- Upgraded nuclei from v3.0.3 to v3.1.0 @secureCodeBoxBot (#2114, #2104)
2826
- Upgraded semgrep from 1.48.0 to 1.51.0 @secureCodeBoxBot (#2112, #2101)
2927
```

‎documentation/docs/contributing/integrating-a-scanner/makefile.md‎

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ This adds the old-wordpress demo-target to your integration tests. You can find
5656
```makefile
5757
#!/usr/bin/make -f
5858
include_guard = set
59-
scanner = kubeaudit
59+
scanner = nmap
6060
custom_scanner = set
6161

6262
include ../../scanners.mk
@@ -67,18 +67,16 @@ deploy-with-scanner:
6767
--set="parser.image.repository=docker.io/$(IMG_NS)/$(parser-prefix)-$(scanner)" \
6868
--set="parser.image.tag=$(IMG_TAG)" \
6969
--set="scanner.image.repository=docker.io/$(IMG_NS)/$(scanner-prefix)-$(scanner)" \
70-
--set="scanner.image.tag=$(IMG_TAG)" \
71-
--set="kubeauditScope=cluster"
70+
--set="scanner.image.tag=$(IMG_TAG)"
7271

7372
deploy-test-deps:
7473
# If not exists create namespace where the tests will be executed
75-
kubectl create namespace kubeaudit-tests --dry-run=client -o yaml | kubectl apply -f -
76-
# Install jshop in kubeaudit-tests namespace
77-
helm -n kubeaudit-tests upgrade --install juice-shop ../../demo-targets/juice-shop/ --wait
74+
kubectl create namespace nmap-tests --dry-run=client -o yaml | kubectl apply -f -
75+
# Install jshop in nmap-tests namespace
76+
helm -n nmap-tests upgrade --install juice-shop ../../demo-targets/juice-shop/ --wait
7877
```
7978

80-
This makefile overrides the deploy-with-scanner target such that the `kubeauditScope` can be overwritten.
81-
Furthermore, it overrides the deploy-test-deps target such that juice-shop is installed in the correct namespace (kubeaudit-tests).
79+
Furthermore, it overrides the deploy-test-deps target such that juice-shop is installed in the correct namespace (nmap-tests).
8280

8381
### Reusing components from other scanners
8482

‎documentation/docs/getting-started/upgrading.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ sidebar_position: 3
1515
### Removed / Replaced ScanTypes
1616

1717
* `typo3scan` was removed as the scanner itself [isn't maintaned anymore](https://github.com/whoot/Typo3Scan?tab=readme-ov-file#unsupported). Most security aspects of typo3 are now hard to verify from the outside as it requires authentication (which is really good). Some typo3 security aspects (e.g. a incomplete installation) can be verified by [nuclei](https://www.securecodebox.io/docs/scanners/nuclei).
18+
* `kubeaudit` was removed as the scanner itself [isn't maintaned anymore](https://github.com/Shopify/kubeaudit?tab=readme-ov-file#-deprecation-notice-). As a replacement you can use the `trivy` with it's `k8s` scanning mode, see [trivy ScanType k8s example](https://www.securecodebox.io/docs/scanners/trivy#k8s).
1819

1920
➡️ [Reference: #2670](https://github.com/secureCodeBox/secureCodeBox/issues/2670)
2021

‎operator/internal/telemetry/telemetry.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var officialScanTypes map[string]bool = map[string]bool{
3131
"git-repo-scanner": true,
3232
"gitleaks": true,
3333
"kube-hunter": true,
34-
"kubeaudit": true,
34+
"kubeaudit": true, // deprecated. we'll keep it in this list to still recieve telemetry data from older versions
3535
"ncrack": true,
3636
"nikto": true,
3737
"nmap": true,

‎scanners/git-repo-scanner/examples/github-secureCodeBox-scan/findings.yaml‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -487,27 +487,6 @@
487487
"archived": false,
488488
},
489489
},
490-
{
491-
"name": "GitHub Repo",
492-
"description": "A GitHub repository",
493-
"category": "Git Repository",
494-
"osi_layer": "APPLICATION",
495-
"severity": "INFORMATIONAL",
496-
"attributes":
497-
{
498-
"id": "303349727",
499-
"web_url": "https://github.com/secureCodeBox/kubeaudit",
500-
"full_name": "secureCodeBox/kubeaudit",
501-
"owner_type": "Organization",
502-
"owner_id": "34573705",
503-
"topics": [],
504-
"owner_name": "secureCodeBox",
505-
"created_at": "2020-10-12T09:58:26Z",
506-
"last_activity_at": "2020-10-12T09:58:28Z",
507-
"visibility": "public",
508-
"archived": false,
509-
},
510-
},
511490
{
512491
"name": "GitHub Repo",
513492
"description": "A GitHub repository",

‎scanners/git-repo-scanner/parser/__testFiles__/git-scanner-test-findings.json‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -520,23 +520,5 @@
520520
"last_activity_at": "2020-10-21T15:11:56Z",
521521
"visibility": "private"
522522
}
523-
},
524-
{
525-
"name": "GitHub Repo",
526-
"description": "A GitHub repository",
527-
"category": "Git Repository",
528-
"osi_layer": "APPLICATION",
529-
"severity": "INFORMATIONAL",
530-
"attributes": {
531-
"id": 303349727,
532-
"web_url": "https://github.com/secureCodeBox/kubeaudit",
533-
"full_name": "secureCodeBox/kubeaudit",
534-
"owner_type": "Organization",
535-
"owner_id": 34573705,
536-
"owner_name": "secureCodeBox",
537-
"created_at": "2020-10-12T09:58:26Z",
538-
"last_activity_at": "2020-10-12T09:58:28Z",
539-
"visibility": "public"
540-
}
541523
}
542524
]

‎scanners/git-repo-scanner/parser/parser.test.js‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -554,24 +554,6 @@ test("should properly parse git-scanner json file", async () => {
554554
"osi_layer": "APPLICATION",
555555
"severity": "INFORMATIONAL",
556556
},
557-
Object {
558-
"attributes": Object {
559-
"created_at": "2020-10-12T09:58:26Z",
560-
"full_name": "secureCodeBox/kubeaudit",
561-
"id": 303349727,
562-
"last_activity_at": "2020-10-12T09:58:28Z",
563-
"owner_id": 34573705,
564-
"owner_name": "secureCodeBox",
565-
"owner_type": "Organization",
566-
"visibility": "public",
567-
"web_url": "https://github.com/secureCodeBox/kubeaudit",
568-
},
569-
"category": "Git Repository",
570-
"description": "A GitHub repository",
571-
"name": "GitHub Repo",
572-
"osi_layer": "APPLICATION",
573-
"severity": "INFORMATIONAL",
574-
},
575557
]
576558
`);
577559
});

0 commit comments

Comments
 (0)