#2680 Handle missing ScheduledScan gracefully by auto-discovery

BorisShek · J12934 · commit 2ff9accb3330 · 2025-01-28T18:30:38.000+01:00
Previously, the Container Auto-Discovery controller logged an error when trying
to fetch a ScheduledScan that was already deleted. This change introduces a check
for `IsNotFound` errors, treating them as expected behavior instead of logging
them as errors.
Now, if a ScheduledScan is not found, an informational log message is recorded
instead of an error. This prevents unnecessary noise in logs.

Signed-off-by: Boris Shek &lt;boris.shek@iteratec.com&gt;
diff --git a/auto-discovery/kubernetes/controllers/container_scan_controller.go b/auto-discovery/kubernetes/controllers/container_scan_controller.go
@@ -427,7 +427,11 @@ func (r *ContainerScanReconciler) getOrphanedScanImageIDs(ctx context.Context, p
 			var scan executionv1.ScheduledScan
 			err := r.Client.Get(ctx, types.NamespacedName{Name: scanName, Namespace: pod.Namespace}, &scan)
 			if err != nil {
-				r.Log.Error(err, "Unable to fetch scan", "name", scanName)
+				if k8sErrors.IsNotFound(err) {
+					r.Log.Info("Scan was already deleted, nothing to do", "name", scanName)
+				} else {
+					r.Log.Error(err, "Unable to fetch scan", "name", scanName)
+				}
 			} else if !r.containerIDInUse(ctx, pod, imageID) {
 				result[cleanedImageID] = append(result[cleanedImageID], scanConfig)
 			}
