From f69073857d51b1eaad01d3dfcf4dbcc985eeaa56 Mon Sep 17 00:00:00 2001 From: Pawel Date: Thu, 6 Jun 2024 22:09:58 +0200 Subject: [PATCH 1/8] bump fake-seam version --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d666d8..bd5b13f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: uses: actions/setup-node@v3 - name: Install Fake Seam - run: npm install -g @seamapi/fake-seam-connect@v1.41.0 + run: npm install -g @seamapi/fake-seam-connect@v1.65.5 - name: Test run: ./gradlew test From 36ad38edc476675e3f7ce4b4b13bfdf71da6514e Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:20:11 +0200 Subject: [PATCH 2/8] check the number of connected accounts --- .../connectedaccounts/ConnectedAccountsTest.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java index 415b65f..040a006 100644 --- a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java +++ b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java @@ -1,16 +1,18 @@ package com.seam.api.connectedaccounts; -import com.seam.api.Seam; -import com.seam.api.TestUtils; -import com.seam.api.TestUtils.FakeSeamStartedResponse; -import com.seam.api.types.ConnectedAccount; -import com.seam.api.types.ConnectedAccountsGetRequest; import java.util.List; + import org.assertj.core.api.Assertions; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; +import com.seam.api.Seam; +import com.seam.api.TestUtils; +import com.seam.api.TestUtils.FakeSeamStartedResponse; +import com.seam.api.types.ConnectedAccount; +import com.seam.api.types.ConnectedAccountsGetRequest; + public final class ConnectedAccountsTest { private static Seam seam; @@ -33,7 +35,7 @@ public static void afterAll() throws InterruptedException { @Test public void test_connected_accounts() { List connectedAccounts = seam.connectedAccounts().list(); - Assertions.assertThat(connectedAccounts).hasSize(2); + Assertions.assertThat(connectedAccounts).hasSizeGreaterThanOrEqualTo(2); String connectedAccountId = connectedAccounts.get(0).getConnectedAccountId().get(); From 7aa0b2de82341d2a918f2d5a95e0667963035dd7 Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:25:31 +0200 Subject: [PATCH 3/8] add scan flag for more build info --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bd5b13f..465f995 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: run: npm install -g @seamapi/fake-seam-connect@v1.65.5 - name: Test - run: ./gradlew test + run: ./gradlew test --scan publish: needs: [ compile, test ] if: github.event_name == 'push' && contains(github.ref, 'refs/tags/') From 503249547006fca16ca09f0eed9392c4d11c8c1c Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:26:41 +0200 Subject: [PATCH 4/8] print for debugging --- .../com/seam/api/accesscode/AccessCodesTest.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java index e619ae5..950f8aa 100644 --- a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java +++ b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java @@ -1,5 +1,13 @@ package com.seam.api.accesscode; +import java.util.List; +import java.util.stream.Collectors; + +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + import com.seam.api.Seam; import com.seam.api.TestUtils; import com.seam.api.TestUtils.FakeSeamStartedResponse; @@ -13,12 +21,6 @@ import com.seam.api.types.AccessCodeStatus; import com.seam.api.types.ActionAttempt; import com.seam.api.types.Device; -import java.util.List; -import java.util.stream.Collectors; -import org.assertj.core.api.Assertions; -import org.junit.jupiter.api.AfterAll; -import org.junit.jupiter.api.BeforeAll; -import org.junit.jupiter.api.Test; public final class AccessCodesTest { @@ -120,6 +122,7 @@ public void test_access_codes() { .delete(AccessCodesDeleteRequest.builder() .accessCodeId(createdAccessCode.getAccessCodeId()) .build()); + System.out.println(deleteActionAttempt); Assertions.assertThat(deleteActionAttempt.getSuccess()).isNotEmpty(); accessCodes = seam.accessCodes() From 86391493e4bfabecb1eb38efe9f77e9e6f7b13e2 Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:31:40 +0200 Subject: [PATCH 5/8] Revert "add scan flag for more build info" This reverts commit 7aa0b2de82341d2a918f2d5a95e0667963035dd7. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 465f995..bd5b13f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: run: npm install -g @seamapi/fake-seam-connect@v1.65.5 - name: Test - run: ./gradlew test --scan + run: ./gradlew test publish: needs: [ compile, test ] if: github.event_name == 'push' && contains(github.ref, 'refs/tags/') From 772fe0188fad91f7c5dee829644697e99bc0c95c Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:31:46 +0200 Subject: [PATCH 6/8] Revert "check the number of connected accounts" This reverts commit 36ad38edc476675e3f7ce4b4b13bfdf71da6514e. --- .../connectedaccounts/ConnectedAccountsTest.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java index 040a006..415b65f 100644 --- a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java +++ b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java @@ -1,17 +1,15 @@ package com.seam.api.connectedaccounts; -import java.util.List; - -import org.assertj.core.api.Assertions; -import org.junit.jupiter.api.AfterAll; -import org.junit.jupiter.api.BeforeAll; -import org.junit.jupiter.api.Test; - import com.seam.api.Seam; import com.seam.api.TestUtils; import com.seam.api.TestUtils.FakeSeamStartedResponse; import com.seam.api.types.ConnectedAccount; import com.seam.api.types.ConnectedAccountsGetRequest; +import java.util.List; +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; public final class ConnectedAccountsTest { @@ -35,7 +33,7 @@ public static void afterAll() throws InterruptedException { @Test public void test_connected_accounts() { List connectedAccounts = seam.connectedAccounts().list(); - Assertions.assertThat(connectedAccounts).hasSizeGreaterThanOrEqualTo(2); + Assertions.assertThat(connectedAccounts).hasSize(2); String connectedAccountId = connectedAccounts.get(0).getConnectedAccountId().get(); From da9d5b63ad2b0df847fa5625d69fdec263d36f6f Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:32:24 +0200 Subject: [PATCH 7/8] check for more than one connected account --- .../com/seam/api/accesscode/AccessCodesTest.java | 1 - .../connectedaccounts/ConnectedAccountsTest.java | 14 ++++++++------ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java index 950f8aa..cd7fc11 100644 --- a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java +++ b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java @@ -122,7 +122,6 @@ public void test_access_codes() { .delete(AccessCodesDeleteRequest.builder() .accessCodeId(createdAccessCode.getAccessCodeId()) .build()); - System.out.println(deleteActionAttempt); Assertions.assertThat(deleteActionAttempt.getSuccess()).isNotEmpty(); accessCodes = seam.accessCodes() diff --git a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java index 415b65f..040a006 100644 --- a/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java +++ b/src/test/java/com/seam/api/connectedaccounts/ConnectedAccountsTest.java @@ -1,16 +1,18 @@ package com.seam.api.connectedaccounts; -import com.seam.api.Seam; -import com.seam.api.TestUtils; -import com.seam.api.TestUtils.FakeSeamStartedResponse; -import com.seam.api.types.ConnectedAccount; -import com.seam.api.types.ConnectedAccountsGetRequest; import java.util.List; + import org.assertj.core.api.Assertions; import org.junit.jupiter.api.AfterAll; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; +import com.seam.api.Seam; +import com.seam.api.TestUtils; +import com.seam.api.TestUtils.FakeSeamStartedResponse; +import com.seam.api.types.ConnectedAccount; +import com.seam.api.types.ConnectedAccountsGetRequest; + public final class ConnectedAccountsTest { private static Seam seam; @@ -33,7 +35,7 @@ public static void afterAll() throws InterruptedException { @Test public void test_connected_accounts() { List connectedAccounts = seam.connectedAccounts().list(); - Assertions.assertThat(connectedAccounts).hasSize(2); + Assertions.assertThat(connectedAccounts).hasSizeGreaterThanOrEqualTo(2); String connectedAccountId = connectedAccounts.get(0).getConnectedAccountId().get(); From a9d15e57fb42f7745fa0a3ad13f24863d4817eed Mon Sep 17 00:00:00 2001 From: Pawel Date: Fri, 7 Jun 2024 00:47:23 +0200 Subject: [PATCH 8/8] change assertion to check for success --- src/test/java/com/seam/api/accesscode/AccessCodesTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java index cd7fc11..821a38a 100644 --- a/src/test/java/com/seam/api/accesscode/AccessCodesTest.java +++ b/src/test/java/com/seam/api/accesscode/AccessCodesTest.java @@ -122,7 +122,7 @@ public void test_access_codes() { .delete(AccessCodesDeleteRequest.builder() .accessCodeId(createdAccessCode.getAccessCodeId()) .build()); - Assertions.assertThat(deleteActionAttempt.getSuccess()).isNotEmpty(); + Assertions.assertThat(deleteActionAttempt.isSuccess()); accessCodes = seam.accessCodes() .createMultiple(AccessCodesCreateMultipleRequest.builder()