fix ReactiveX#5468: eager hooks onError call (ReactiveX#5470)

DeepSpawn · akarnokd · commit b8f3cedefb35 · 2017-07-06T11:54:00.000+02:00
* fix ReactiveX#5468: eager hooks onError call Move the call to RxJavaHooks into the catch block, so we only report it if the underlying subscriber throws in its onError method. This brings the behaviour in line with that of SafeSubscriber, which only call Hooks.onError inside the catch * ReactiveX#5468 move hooks OnError into correct if block
diff --git a/src/main/java/rx/observers/SafeCompletableSubscriber.java b/src/main/java/rx/observers/SafeCompletableSubscriber.java
@@ -54,8 +54,8 @@ public void onCompleted() {
 
     @Override
     public void onError(Throwable e) {
-        RxJavaHooks.onError(e);
         if (done) {
+            RxJavaHooks.onError(e);
             return;
         }
         done = true;

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,8 @@ public void onCompleted() {`
`54`	`54`
`55`	`55`	`@Override`
`56`	`56`	`public void onError(Throwable e) {`
`57`		`- RxJavaHooks.onError(e);`
`58`	`57`	`if (done) {`
	`58`	`+ RxJavaHooks.onError(e);`
`59`	`59`	`return;`
`60`	`60`	`}`
`61`	`61`	`done = true;`