Fix GC on PyObject during Finalizing

vmuriart · vmuriart · commit c69297e1da11 · 2017-02-07T19:02:07.000-07:00
Similar to how `PythonDerivedType` finalizes. Closes pythonnet#364 Possibly related to pythonnet#245
diff --git a/src/runtime/pyobject.cs b/src/runtime/pyobject.cs
@@ -113,7 +113,7 @@ protected virtual void Dispose(bool disposing)
         {
             if (!disposed)
             {
-                if (Runtime.Py_IsInitialized() > 0)
+                if (Runtime.Py_IsInitialized() > 0 && !Runtime.IsFinalizing)
                 {
                     IntPtr gs = PythonEngine.AcquireLock();
                     Runtime.XDecref(obj);

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ protected virtual void Dispose(bool disposing)`
`113`	`113`	`{`
`114`	`114`	`if (!disposed)`
`115`	`115`	`{`
`116`		`- if (Runtime.Py_IsInitialized() > 0)`
	`116`	`+ if (Runtime.Py_IsInitialized() > 0 && !Runtime.IsFinalizing)`
`117`	`117`	`{`
`118`	`118`	`IntPtr gs = PythonEngine.AcquireLock();`
`119`	`119`	`Runtime.XDecref(obj);`