add test for deleting blob with generation

sdigit · sdigit · commit e84fe39dff72 · 2018-08-09T15:45:42.000-05:00
diff --git a/storage/tests/unit/test_blob.py b/storage/tests/unit/test_blob.py
@@ -543,6 +543,18 @@ def test_delete(self):
         self.assertFalse(blob.exists())
         self.assertEqual(bucket._deleted, [(BLOB_NAME, None)])
 
+    def test_delete_with_generation(self):
+        BLOB_NAME = 'blob-name'
+        not_found_response = ({'status': http_client.NOT_FOUND}, b'')
+        connection = _Connection(not_found_response)
+        client = _Client(connection)
+        bucket = _Bucket(client)
+        blob = self._make_one(BLOB_NAME, bucket=bucket)
+        bucket._blobs[BLOB_NAME] = 1
+        blob.delete(generation=blob.generation)
+        self.assertFalse(blob.exists())
+        self.assertEqual(bucket._deleted, [(BLOB_NAME, None)])
+
     def test__get_transport(self):
         client = mock.Mock(spec=[u'_credentials', '_http'])
         client._http = mock.sentinel.transport
@@ -3027,7 +3039,7 @@ def __init__(self, client=None, name='name', user_project=None):
         self.path = '/b/' + name
         self.user_project = user_project
 
-    def delete_blob(self, blob_name, client=None):
+    def delete_blob(self, blob_name, client=None, generation=None):
         del self._blobs[blob_name]
         self._deleted.append((blob_name, client))
 
diff --git a/storage/tests/unit/test_bucket.py b/storage/tests/unit/test_bucket.py
@@ -874,7 +874,7 @@ def __init__(self, name, bucket_name):
                 self.path = '/b/%s/o/%s' % (bucket_name, name)
                 self._deleted = []
 
-            def delete(self, client=None):
+            def delete(self, client=None, generation=None):
                 self._deleted.append(client)
 
         blob = _Blob(BLOB_NAME, BUCKET_NAME)
