objexcept: Optimize using messages without formatting substitutions.

pfalcon · pfalcon · commit 29c4f92e13f2 · 2015-02-15T22:41:14.000+03:00
They are directly cast to str object, skipping allocation of formatting
buffer.
diff --git a/py/objexcept.c b/py/objexcept.c
@@ -349,15 +349,19 @@ mp_obj_t mp_obj_new_exception_msg_varg(const mp_obj_type_t *exc_type, const char
             // no message
             assert(0);
         } else {
-            // render exception message and store as .args[0]
-            // TODO: optimize bufferbloat
-            vstr_t vstr;
-            vstr_init(&vstr, 16);
-            va_list ap;
-            va_start(ap, fmt);
-            vstr_vprintf(&vstr, fmt, ap);
-            va_end(ap);
-            o->args->items[0] = mp_obj_new_str_from_vstr(&mp_type_str, &vstr);
+            if (strchr(fmt, '%') == NULL) {
+                // no formatting substitutions, avoid allocating vstr.
+                o->args->items[0] = mp_obj_new_str(fmt, strlen(fmt), false);
+            } else {
+                // render exception message and store as .args[0]
+                va_list ap;
+                vstr_t vstr;
+                vstr_init(&vstr, 16);
+                va_start(ap, fmt);
+                vstr_vprintf(&vstr, fmt, ap);
+                va_end(ap);
+                o->args->items[0] = mp_obj_new_str_from_vstr(&mp_type_str, &vstr);
+            }
         }
     }
 
