Remove some dead code from LegacyInlineFlowBox::nodeAtPoint

anttijk · anttijk · commit 2a4b62074189 · 2021-08-10T19:50:47.000Z
https://bugs.webkit.org/show_bug.cgi?id=228960 Reviewed by Alan Bujtas. * rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::nodeAtPoint): This hit test quirk got accidentally disabled 7 years ago (in http://trac.webkit.org/changeset/170875/webkit) and this became dead code. No one has complained. Canonical link: https://commits.webkit.org/240401@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2021-08-10  Antti Koivisto  <antti@apple.com>
+
+        Remove some dead code from LegacyInlineFlowBox::nodeAtPoint
+        https://bugs.webkit.org/show_bug.cgi?id=228960
+
+        Reviewed by Alan Bujtas.
+
+        * rendering/LegacyInlineFlowBox.cpp:
+        (WebCore::LegacyInlineFlowBox::nodeAtPoint):
+
+        This hit test quirk got accidentally disabled 7 years ago (in http://trac.webkit.org/changeset/170875/webkit)
+        and this became dead code. No one has complained.
+
 2021-08-10  Ben Nham  <nham@apple.com>
 
         Fix nested resource load tracepoints
diff --git a/Source/WebCore/rendering/LegacyInlineFlowBox.cpp b/Source/WebCore/rendering/LegacyInlineFlowBox.cpp
@@ -1167,17 +1167,6 @@ bool LegacyInlineFlowBox::nodeAtPoint(const HitTestRequest& request, HitTestResu
             return false;
     }
 
-    // Constrain our hit testing to the line top and bottom if necessary.
-    bool noQuirksMode = renderer().document().inNoQuirksMode();
-    if (!noQuirksMode && !hasTextChildren() && !(descendantsHaveSameLineHeightAndBaseline() && hasTextDescendants())) {
-        LegacyRootInlineBox& rootBox = root();
-        LayoutUnit top { isHorizontal() ? y() : x()};
-        LayoutUnit logicalHeight { isHorizontal() ? height() : width() };
-        LayoutUnit bottom = std::min(rootBox.lineBottom(), top + logicalHeight);
-        top = std::max(rootBox.lineTop(), top);
-        logicalHeight = bottom - top;
-    }
-
     // Move x/y to our coordinates.
     FloatRect rect(frameRect());
     flipForWritingMode(rect);
