From 80afe4334c15cf5bdcf9fc48a494bf1c83645b1e Mon Sep 17 00:00:00 2001
From: Justin Rusbatch <jrusbatch@gmail.com>
Date: Tue, 23 Dec 2014 18:34:16 -0500
Subject: [PATCH] Remove Code Analysis from the build script

---
 build/Build.proj            | 37 +------------------------------------
 build/ScriptCs.Common.props |  7 ++-----
 2 files changed, 3 insertions(+), 41 deletions(-)

diff --git a/build/Build.proj b/build/Build.proj
index d8e01df7..7138da9f 100644
--- a/build/Build.proj
+++ b/build/Build.proj
@@ -16,15 +16,8 @@
     <NuGetExePath>$(Root).nuget\NuGet.exe</NuGetExePath>
 
     <CommonVersionInfoPath>$([System.IO.Path]::Combine( $(Root), 'common\CommonVersionInfo.cs' ))</CommonVersionInfoPath>
-
-    <VisualStudioVersion Condition=" '$(VisualStudioVersion)' == '' " >11.0</VisualStudioVersion>
-    <CodeAnalysisToolPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeAnalysis\</CodeAnalysisToolPath>
-    <CodeAnalysisTargetsPath>$(CodeAnalysisToolPath)Microsoft.CodeAnalysis.targets</CodeAnalysisTargetsPath>
-    <CodeAnalysisRuleSetDirectories>$(Root)</CodeAnalysisRuleSetDirectories>
   </PropertyGroup>
 
-  <Import Project="$(CodeAnalysisTargetsPath)" Condition=" Exists('$(CodeAnalysisTargetsPath)') " />
-
   <ItemGroup>
     <Solution Include="$(Root)*.sln">
       <AdditionalProperties>
@@ -38,7 +31,7 @@
     <TestProjects Include="$(Root)test\**\*.csproj" />
   </ItemGroup>
 
-  <Target Name="FullBuild" DependsOnTargets="Clean; Build; CodeAnalysis; Test; Package" />
+  <Target Name="FullBuild" DependsOnTargets="Clean; Build; Test; Package" />
 
   <Target Name="Clean" DependsOnTargets="_CleanSolution; _CleanArtifacts">
     <MakeDir Directories="$(ArtifactsPath)" Condition=" !Exists('$(ArtifactsPath)') " />
@@ -50,29 +43,6 @@
     </MSBuild>
   </Target>
 
-  <Target Name="CodeAnalysis" DependsOnTargets="Build; _CopyBinariesToArtifactsDirectory">
-    <Warning Text="Code Analysis could not be performed because the code analysis tools were not found."
-             Condition=" !Exists('$(CodeAnalysisTargetsPath)') Or !Exists('$(CodeAnalysisPath)') " />
-    
-    <ItemGroup>
-      <ReferenceAssemblies Include="$(Root)packages\**\lib\**\*.dll" />
-      <ReferenceDirectories Include="%(ReferenceAssemblies.RootDir)%(ReferenceAssemblies.Directory)\" />
-    </ItemGroup>
-
-    <CodeAnalysis Assemblies="@(ProjectAssemblies)" 
-                  ToolPath="$(CodeAnalysisPath)"
-                  RuleSet="ScriptCs.ruleset" 
-                  RuleSetDirectories="$(CodeAnalysisRuleSetDirectories)"
-                  DependentAssemblyPaths="@(ReferenceDirectories)" 
-                  SearchGlobalAssemblyCache="false" 
-                  AdditionalOptions="/assemblyCompareMode:StrongNameIgnoringVersion"
-                  LogFile="$(ArtifactsPath)CodeAnalysisResults.xml" ForceOutput="true"
-                  FailOnMissingRules="true" IgnoreMissingIndirectReferences="false"
-                  Condition=" Exists('$(CodeAnalysisTargetsPath)') And Exists('$(CodeAnalysisPath)') ">
-      <Output ItemName="CodeAnalysisResults" TaskParameter="FilesWritten" />
-    </CodeAnalysis>
-  </Target>
-
   <Target Name="Test" DependsOnTargets="Build">
     <ItemGroup>
       <TestAssemblies Include="$(Root)test\**\bin\$(Configuration)\**\*.Tests.dll;$(Root)test\**\bin\$(Configuration)\**\*.Tests.Acceptance.dll" />
@@ -143,9 +113,4 @@
     
     <Copy SourceFiles="@(FilesToCopy)" DestinationFolder="$(ArtifactsPath)bin\" />
   </Target>
-
-  <Target Name="_PublishCodeAnalysisResults" AfterTargets="CodeAnalysis" Condition=" '$(TeamCity)' == 'true' ">
-    <Message Text="##teamcity[importData type='FxCop' path='%(CodeAnalysisResults.FullPath)']" 
-             Condition=" Exists('%(CodeAnalysisResults.FullPath)') " />
-  </Target>
 </Project>
\ No newline at end of file
diff --git a/build/ScriptCs.Common.props b/build/ScriptCs.Common.props
index a289f418..0a1bcee9 100644
--- a/build/ScriptCs.Common.props
+++ b/build/ScriptCs.Common.props
@@ -8,9 +8,6 @@
     <DebugSymbols>true</DebugSymbols>
 
     <StyleCopEnabled Condition=" '$(StyleCopEnabled)' == '' ">true</StyleCopEnabled>
-    <RunCodeAnalysis Condition=" '$(RunCodeAnalysis)' == '' " >false</RunCodeAnalysis>
-
-    <DefineConstants Condition=" '$(RunCodeAnalysis)' == 'true' ">$(DefineConstants);CODE_ANALYSIS</DefineConstants>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(OS)' != 'Windows_NT' ">
@@ -21,13 +18,13 @@
   <PropertyGroup Condition=" '$(Platform)' == 'AnyCPU' ">
     <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
-  
+
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
     <DefineConstants>$(DefineConstants);DEBUG</DefineConstants>
     <DebugType>full</DebugType>
     <Optimize>false</Optimize>
   </PropertyGroup>
-  
+
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
     <Optimize>true</Optimize>