Skip to content

Remove Code Analysis from the build script #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filipw merged 1 commit into from
Dec 23, 2014
Merged

Remove Code Analysis from the build script #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 1 addition & 36 deletions build/Build.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,8 @@
<NuGetExePath>$(Root).nuget\NuGet.exe</NuGetExePath>

<CommonVersionInfoPath>$([System.IO.Path]::Combine( $(Root), 'common\CommonVersionInfo.cs' ))</CommonVersionInfoPath>

<VisualStudioVersion Condition=" '$(VisualStudioVersion)' == '' " >11.0</VisualStudioVersion>
<CodeAnalysisToolPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\CodeAnalysis\</CodeAnalysisToolPath>
<CodeAnalysisTargetsPath>$(CodeAnalysisToolPath)Microsoft.CodeAnalysis.targets</CodeAnalysisTargetsPath>
<CodeAnalysisRuleSetDirectories>$(Root)</CodeAnalysisRuleSetDirectories>
</PropertyGroup>

<Import Project="$(CodeAnalysisTargetsPath)" Condition=" Exists('$(CodeAnalysisTargetsPath)') " />

<ItemGroup>
<Solution Include="$(Root)*.sln">
<AdditionalProperties>
Expand All @@ -38,7 +31,7 @@
<TestProjects Include="$(Root)test\**\*.csproj" />
</ItemGroup>

<Target Name="FullBuild" DependsOnTargets="Clean; Build; CodeAnalysis; Test; Package" />
<Target Name="FullBuild" DependsOnTargets="Clean; Build; Test; Package" />

<Target Name="Clean" DependsOnTargets="_CleanSolution; _CleanArtifacts">
<MakeDir Directories="$(ArtifactsPath)" Condition=" !Exists('$(ArtifactsPath)') " />
Expand All @@ -50,29 +43,6 @@
</MSBuild>
</Target>

<Target Name="CodeAnalysis" DependsOnTargets="Build; _CopyBinariesToArtifactsDirectory">
<Warning Text="Code Analysis could not be performed because the code analysis tools were not found."
Condition=" !Exists('$(CodeAnalysisTargetsPath)') Or !Exists('$(CodeAnalysisPath)') " />

<ItemGroup>
<ReferenceAssemblies Include="$(Root)packages\**\lib\**\*.dll" />
<ReferenceDirectories Include="%(ReferenceAssemblies.RootDir)%(ReferenceAssemblies.Directory)\" />
</ItemGroup>

<CodeAnalysis Assemblies="@(ProjectAssemblies)"
ToolPath="$(CodeAnalysisPath)"
RuleSet="ScriptCs.ruleset"
RuleSetDirectories="$(CodeAnalysisRuleSetDirectories)"
DependentAssemblyPaths="@(ReferenceDirectories)"
SearchGlobalAssemblyCache="false"
AdditionalOptions="/assemblyCompareMode:StrongNameIgnoringVersion"
LogFile="$(ArtifactsPath)CodeAnalysisResults.xml" ForceOutput="true"
FailOnMissingRules="true" IgnoreMissingIndirectReferences="false"
Condition=" Exists('$(CodeAnalysisTargetsPath)') And Exists('$(CodeAnalysisPath)') ">
<Output ItemName="CodeAnalysisResults" TaskParameter="FilesWritten" />
</CodeAnalysis>
</Target>

<Target Name="Test" DependsOnTargets="Build">
<ItemGroup>
<TestAssemblies Include="$(Root)test\**\bin\$(Configuration)\**\*.Tests.dll;$(Root)test\**\bin\$(Configuration)\**\*.Tests.Acceptance.dll" />
Expand Down Expand Up @@ -143,9 +113,4 @@

<Copy SourceFiles="@(FilesToCopy)" DestinationFolder="$(ArtifactsPath)bin\" />
</Target>

<Target Name="_PublishCodeAnalysisResults" AfterTargets="CodeAnalysis" Condition=" '$(TeamCity)' == 'true' ">
<Message Text="##teamcity[importData type='FxCop' path='%(CodeAnalysisResults.FullPath)']"
Condition=" Exists('%(CodeAnalysisResults.FullPath)') " />
</Target>
</Project>
7 changes: 2 additions & 5 deletions build/ScriptCs.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
<DebugSymbols>true</DebugSymbols>

<StyleCopEnabled Condition=" '$(StyleCopEnabled)' == '' ">true</StyleCopEnabled>
<RunCodeAnalysis Condition=" '$(RunCodeAnalysis)' == '' " >false</RunCodeAnalysis>

<DefineConstants Condition=" '$(RunCodeAnalysis)' == 'true' ">$(DefineConstants);CODE_ANALYSIS</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition=" '$(OS)' != 'Windows_NT' ">
Expand All @@ -21,13 +18,13 @@
<PropertyGroup Condition=" '$(Platform)' == 'AnyCPU' ">
<Prefer32Bit>false</Prefer32Bit>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DefineConstants>$(DefineConstants);DEBUG</DefineConstants>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
Expand Down