Skip to content

refactoring after #830#877

Merged
filipw merged 3 commits into
scriptcs:devfrom
adamralph:refactor-830
Dec 23, 2014
Merged

refactoring after #830#877
filipw merged 3 commits into
scriptcs:devfrom
adamralph:refactor-830

Conversation

@adamralph
Copy link
Copy Markdown
Contributor

@adamralph adamralph commented Dec 21, 2014

  • introduce IRepl
  • move IReplEngine to own file
  • add guards
  • remove redundant code
  • fix code formatting
  • add readonly

also fixes #434

@adamralph adamralph mentioned this pull request Dec 21, 2014
Merged
@adamralph adamralph mentioned this pull request Dec 21, 2014
Closed
@filipw
Copy link
Copy Markdown
Member

filipw commented Dec 23, 2014

you should also register IRepl against Repl in the services builder, inject it so that it's not newed up, and expose it publicly to allow for overrides like all the other services. This was the goal of #434.

@adamralph
Copy link
Copy Markdown
Contributor Author

adamralph commented Dec 23, 2014

Will do.

@adamralph
make REPL injectable and overrideable like other services
93e603d
@adamralph
refactor:
98068e2 
 - redundant code
 - line length
 - guard clauses
 - EOL at end of file
 - readonly fields
 - replace if with null coalesce
 - replace if with inline conditional
 - whitespace
@adamralph
Copy link
Copy Markdown
Contributor Author

adamralph commented Dec 23, 2014

Done.

@adamralph adamralph assigned filipw and unassigned adamralph Dec 23, 2014
@filipw
Copy link
Copy Markdown
Member

filipw commented Dec 23, 2014

great! thank you!

filipw added a commit that referenced this pull request Dec 23, 2014
@filipw
Merge pull request #877 from adamralph/refactor-830
09bb9af 
refactoring after #830
@filipw filipw merged commit 09bb9af into scriptcs:dev Dec 23, 2014
@adamralph adamralph deleted the refactor-830 branch December 23, 2014 11:36
@adamralph adamralph added this to the v0.12 milestone Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@filipw filipw

Labels

child PR refactoring

Projects

None yet

Milestone

v0.12

Development

Successfully merging this pull request may close these issues.

Make REPL injectable and overrideable like other services

2 participants

@adamralph @filipw