Skip to content

#629 #630 changed to last in wins for line processors#725

Merged
khellang merged 1 commit into
scriptcs:devfrom
adamralph:629-630
May 30, 2014
Merged

#629 #630 changed to last in wins for line processors#725
khellang merged 1 commit into
scriptcs:devfrom
adamralph:629-630

Conversation

@adamralph
Copy link
Copy Markdown
Contributor

relaxed type constraints for line processor override
corrected exception when line processor override is of invalid type
reverted ScriptServicesRegistration._overrides to being private
split DirectiveLineProcessor and IDirectiveLineProcessor
removed redundant code

closes #629
closes #630

@adamralph adamralph mentioned this pull request May 29, 2014
relaxed type constraints for line processor override
corrected exception when line processor override is of invalid type
reverted ScriptServicesRegistration._overrides to being private
split DirectiveLineProcessor and IDirectiveLineProcessor
removed redundant code
@adamralph
Copy link
Copy Markdown
Contributor Author

rebased

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh... this 😰

khellang added a commit that referenced this pull request May 30, 2014
#629 #630 changed to last in wins for line processors
@khellang khellang merged commit ca1f9da into scriptcs:dev May 30, 2014
@adamralph adamralph deleted the 629-630 branch May 30, 2014 14:55
@khellang khellang added this to the v0.10 milestone Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom line processors are considered "code" by FilePreProcessor. Cannot add a custom LineProcessor via IModuleConfiguration

2 participants