Upgrade to Roslyn packages 1.0.0 rc2#1064
Merged
Merged
Conversation
add a build script which creates a nuget package
use latest AssemblyReferences version
Renaming to scriptcs-engines
Update README.md
fix build script after rename and split into 3 projects
Member
Author
|
can we move forward with this? I have been keeping this branch up to date for over 2 months now and I see no reason for us to stay behind on this. The only issue I can see, and I want everyone to be every of is that I renamed the roslyn module to |
…w/scriptcs into feature/roslyn-engines-rc2
Contributor
|
Should also fix #1095 |
Member
|
👍 |
khellang
added a commit
that referenced
this pull request
Sep 29, 2015
[WIP] - Upgrade to Roslyn packages 1.0.0 rc2
Member
Member
Author
Contributor
|
Rockin! On Tue, Sep 29, 2015 at 12:55 PM Filip W notifications@github.com wrote:
|
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Opening the PR for visibility and potential discussions.
This PR upgrade old Roslyn CTP from September 2012 to version 1.0.0 RC2 (.NET 4.5 compatible). Also includes a VB engine. The core work was done in this repo already https://github.com/scriptcs/scriptcs-engines
Version 1.1.0-beta is .NET 4.6 only so we will have to discuss separately what to do about it.
TODO
prepackages)ILog, they don't)build.cmd(note: acceptance tests still fail)scriptcs.csharpandscriptcs.visualbasic)Questions & issues
ScriptCs.CSharp, should we keep this name or stick withScriptCs.Engine.Roslyn? Right now I renamed everything tocsharpandvisualbasicrespectively, soroslynis no longer visible anywhereNext steps
Update to Roslyn 1.1.0-beta? However, as mentioned, that's .NET 4.6 only.