Skip to content

Commit c9dfa62

Browse files
committed
fix Type resolution for builder pattern in ServiceBuilderOAuth10a (thanks to https://github.com/mgyucht)
1 parent f0da256 commit c9dfa62

File tree

4 files changed

+15
-0
lines changed

4 files changed

+15
-0
lines changed

changelog

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[SNAPSHOT]
22
* make Response implements Closeable (thanks to https://github.com/omaric)
3+
* fix Type resolution for builder pattern in ServiceBuilderOAuth10a (thanks to https://github.com/mgyucht)
34

45
[6.8.0]
56
* Add debug output to OAuth2Service (thanks to https://github.com/rbarbey)

scribejava-core/src/main/java/com/github/scribejava/core/builder/ServiceBuilderCommon.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.github.scribejava.core.httpclient.HttpClient;
44
import com.github.scribejava.core.httpclient.HttpClientConfig;
55
import com.github.scribejava.core.oauth.OAuthService;
6+
import java.io.OutputStream;
67

78
/**
89
* Implementation of the Builder pattern, with a fluent interface that creates a {@link OAuthService}
@@ -45,4 +46,8 @@ public interface ServiceBuilderCommon {
4546
ServiceBuilderCommon httpClient(HttpClient httpClient);
4647

4748
ServiceBuilderCommon userAgent(String userAgent);
49+
50+
ServiceBuilderCommon debugStream(OutputStream debugStream);
51+
52+
ServiceBuilderCommon debug();
4853
}

scribejava-core/src/main/java/com/github/scribejava/core/builder/ServiceBuilderOAuth10a.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ public interface ServiceBuilderOAuth10a extends ServiceBuilderCommon {
2626
@Override
2727
ServiceBuilderOAuth10a userAgent(String userAgent);
2828

29+
@Override
2930
ServiceBuilderOAuth10a debugStream(OutputStream debugStream);
3031

32+
@Override
3133
ServiceBuilderOAuth10a debug();
3234

3335
/**

scribejava-core/src/main/java/com/github/scribejava/core/builder/ServiceBuilderOAuth20.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.github.scribejava.core.httpclient.HttpClient;
55
import com.github.scribejava.core.httpclient.HttpClientConfig;
66
import com.github.scribejava.core.oauth.OAuth20Service;
7+
import java.io.OutputStream;
78

89
public interface ServiceBuilderOAuth20 extends ServiceBuilderCommon {
910

@@ -25,6 +26,12 @@ public interface ServiceBuilderOAuth20 extends ServiceBuilderCommon {
2526
@Override
2627
ServiceBuilderOAuth20 userAgent(String userAgent);
2728

29+
@Override
30+
ServiceBuilderOAuth20 debugStream(OutputStream debugStream);
31+
32+
@Override
33+
ServiceBuilderOAuth20 debug();
34+
2835
ServiceBuilderOAuth20 responseType(String responseType);
2936

3037
/**

0 commit comments

Comments
 (0)