introduce PMD/category/java/codestyle.xml/UselessParentheses rule

kullfar · kullfar · commit 91ce572f988c · 2019-04-03T14:30:05.000+03:00
diff --git a/pmd.xml b/pmd.xml
@@ -50,4 +50,5 @@
     <rule ref="category/java/codestyle.xml/UnnecessaryFullyQualifiedName" />
     <rule ref="category/java/codestyle.xml/UnnecessaryModifier" />
     <rule ref="category/java/codestyle.xml/UnnecessaryReturn" />
+    <rule ref="category/java/codestyle.xml/UselessParentheses" />
 </ruleset>
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/java8/Base64.java b/scribejava-core/src/main/java/com/github/scribejava/core/java8/Base64.java
@@ -627,7 +627,7 @@ private int outLength(byte[] src, int sp, int sl) {
                 while (sp < sl) {
                     int b = src[sp++] & 0xff;
                     if (b == '=') {
-                        len -= (sl - sp + 1);
+                        len -= sl - sp + 1;
                         break;
                     }
                     b = base64[b];

Original file line number	Diff line number	Diff line change
`@@ -627,7 +627,7 @@ private int outLength(byte[] src, int sp, int sl) {`
`627`	`627`	`while (sp < sl) {`
`628`	`628`	`int b = src[sp++] & 0xff;`
`629`	`629`	`if (b == '=') {`
`630`		`- len -= (sl - sp + 1);`
	`630`	`+ len -= sl - sp + 1;`
`631`	`631`	`break;`
`632`	`632`	`}`
`633`	`633`	`b = base64[b];`