Stop using infinity for float/double bounds

ctrueden · ctrueden · commit 33c4ea1502eb · 2023-12-06T12:18:59.000-06:00
Instead, we use Float/Double.MAX_VALUE.
diff --git a/src/scyjava/_types.py b/src/scyjava/_types.py
@@ -284,7 +284,7 @@ def numeric_bounds(the_type: type) -> Union[Tuple[int, int], Tuple[float, float]
     """
     Get the minimum and maximum values for the given numeric type.
     For example, a Java long returns (int(Long.MIN_VALUE), int(Long.MAX_VALUE)),
-    whereas a Java double returns (float("-inf"), float("inf")).
+    whereas a Java double returns (double(-Double.MAX_VALUE), double(Double.MAX_VALUE)).
 
     :param the_type: The type whose minimum and maximum values are needed.
     :return:
@@ -307,8 +307,13 @@ def numeric_bounds(the_type: type) -> Union[Tuple[int, int], Tuple[float, float]
         Long = jimport("java.lang.Long")
         return int(Long.MIN_VALUE), int(Long.MAX_VALUE)
 
-    if is_jfloat(the_type) or is_jdouble(the_type):
-        return float("-inf"), float("inf")
+    if is_jfloat(the_type):
+        Float = jimport("java.lang.Float")
+        return float(-Float.MAX_VALUE), float(Float.MAX_VALUE)
+
+    if is_jdouble(the_type):
+        Double = jimport("java.lang.Double")
+        return float(-Double.MAX_VALUE), float(Double.MAX_VALUE)
 
     return None, None
 
diff --git a/tests/test_types.py b/tests/test_types.py
@@ -22,6 +22,6 @@ def test_numeric_bounds(self):
         assert (-2147483648, 2147483647) == numeric_bounds(type(v_int))
         assert (-9223372036854775808, 9223372036854775807) == numeric_bounds(type(v_long))
         assert (None, None) == numeric_bounds(type(v_bigint))
-        assert (float("-inf"), float("inf")) == numeric_bounds(type(v_float))
-        assert (float("-inf"), float("inf")) == numeric_bounds(type(v_double))
+        assert (-3.4028234663852886e+38, 3.4028234663852886e+38) == numeric_bounds(type(v_float))
+        assert (-1.7976931348623157e+308, 1.7976931348623157e+308) == numeric_bounds(type(v_double))
         assert (None, None) == numeric_bounds(type(v_bigdec))
