Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CJ077/scripting-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: scijava/scripting-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 13 files changed
  • 3 contributors

Commits on Jul 1, 2021

  1. Switch from Travis CI to GitHub Actions

    Curtis Rueden committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    fde688f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. CI: build release tags

    Curtis Rueden committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    9aa1f2b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. POM: Stop using git:// protocol with github.com

    The GitHub platform is discontinuing support for it.
    
    See: https://github.blog/2021-09-01-improving-git-protocol-security-github/#whats-changing
    Curtis Rueden committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    67489be View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. CI: cache ~/.m2/repository correctly

    Curtis Rueden committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    e9b4179 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2025

  1. Configuration menu
    Copy the full SHA
    714c514 View commit details
    Browse the repository at this point in the history
  2. Merge pull request scijava#15 from odinsbane/fixing-classpath

    Switched using classloader to using classgraph library.
    Curtis Rueden authored Aug 14, 2025
    Configuration menu
    Copy the full SHA
    029c740 View commit details
    Browse the repository at this point in the history
  3. POM: update parent to pom-scijava 42.0.0

    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    b72274b View commit details
    Browse the repository at this point in the history
  4. Update copyright blurbs for 2025

    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    c3fecc7 View commit details
    Browse the repository at this point in the history
  5. POM: declare classgraph version as a property

    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    40cb95d View commit details
    Browse the repository at this point in the history
  6. Update CI to current standards; rename main branch

    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    d6918c0 View commit details
    Browse the repository at this point in the history
  7. POM: bump version to 1.0.0-SNAPSHOT

    It's past time to start deploying SciJava components
    like this one to Maven Central!
    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    31fd9c6 View commit details
    Browse the repository at this point in the history
  8. POM: use HTTPS for schema location URL

    Maven no longer supports plain HTTP for the schema location.
    
    And using HTTP now generates errors in Eclipse (and probably other IDEs).
    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    e8af761 View commit details
    Browse the repository at this point in the history
  9. Bump to next development cycle

    Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
    Curtis Rueden committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    4b1c9dd View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2026

  1. Update license headers for 2026

    Curtis Rueden committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    2d382bf View commit details
    Browse the repository at this point in the history
  2. POM: update parent to pom-scijava 44.0.0

    Curtis Rueden committed Jun 14, 2026
    Configuration menu
    Copy the full SHA
    b63325f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2026

  1. Update CI to current configuration

    Curtis Rueden committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    9ae808e View commit details
    Browse the repository at this point in the history
  2. Fix extraneous whitespace in generated POM files

    With Java 11 only (not 8, 17, or 21!), tests failed with errors like:
    
      java.lang.AssertionError:
        Unexpected: META-INF/maven/
                org.scijava.scripting.java
            /
                Dummy
            /pom.xml
    
    Cause: the generated pom.xml has whitespace-polluted <groupId>,
    <artifactId>, and <version> values.
    
    Here's what was happening:
    
    1. fakePOM() builds an XML document where each element's content is
       stored as a CDATA section via document.createCDATASection(content).
    
    2. The transformer is configured with OutputKeys.INDENT = "yes".
    
    3. In Java 8 (Xalan), the transformer writes CDATA content inline:
       <groupId><![CDATA[org.scijava.scripting.java]]></groupId>.
    
    4. In Java 11, the internal XSLT transformer changed its indentation
       behavior for CDATA nodes — it treats a CDATA section as a child node
       distinct from inline text, and inserts a newline + indent before it
       and after it:
    
         <groupId>
             <![CDATA[org.scijava.scripting.java]]>
         </groupId>
    
    5. When MiniMaven parses this POM back, getTextContent() on <groupId>
       returns "\n        org.scijava.scripting.java\n    ", which then gets
       embedded verbatim into the JAR entry path and into download URLs —
       causing the MalformedURLException and the wrong JAR entry names.
    
    The fix is in the append method: replace createCDATASection with
    createTextNode. XSLT transformers universally treat text-only elements
    (those with a single text-node child and no element children) as opaque
    and don't inject indentation whitespace inside them.
    
    CDATA sections and text nodes are semantically identical in XML, but
    Java 11's XSLT transformer treats a CDATA node as a distinct child and
    wraps it with indentation whitespace when INDENT=yes. Plain text nodes
    in text-only elements are left inline.
    
    Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
    Curtis Rueden and claude committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    b7075bd View commit details
    Browse the repository at this point in the history
  3. Bump to next development cycle

    Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
    Curtis Rueden committed Jun 15, 2026
    Configuration menu
    Copy the full SHA
    a0534cd View commit details
    Browse the repository at this point in the history
Loading