Skip to content

Commit dda72d0

Browse files
ctruedenctrueden
committed
Move Types.isApplicable* methods to MatchingUtils
The isApplicable methods are *almost* not used at all anymore... only the inputsMatch method of RuntimeSafeMatchingRoutine calls it as part of a final check to evaluate input suitability of op candidates, as part of its typesMatch(OpCandidate) method. But according to @gselzer, it's actually the *other* typesMatch method, typesMatch(Type, Type, Map<TypeVariable<?>, Type>), which is the real workhorse of the system, performing the primary type matching check. In lieu of fully cleaning up this mess, this commit moves the almost-obsolete methods from the Types class, where they were public and exported, to the MatchingUtils class, where they are internal and encapsulated. Later, we can tweak the internal scijava-ops-engine code to fully eliminate these methods. But in the meantime, at least they won't become permanent public API of the scijava-types module.
1 parent 82166ff commit dda72d0

File tree

6 files changed

+931
-905
lines changed

6 files changed

+931
-905
lines changed

‎scijava-ops-engine/pom.xml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,12 @@
194194
<artifactId>junit-jupiter-engine</artifactId>
195195
<scope>test</scope>
196196
</dependency>
197+
<dependency>
198+
<groupId>org.scijava</groupId>
199+
<artifactId>scijava-testutil</artifactId>
200+
<version>${project.version}</version>
201+
<scope>test</scope>
202+
</dependency>
197203
</dependencies>
198204

199205
<build>

0 commit comments

Comments
 (0)