Add invalid ns/op help string

hinerm · hinerm · commit baee2b5b0c32 · 2024-01-19T12:52:18.000-06:00
diff --git a/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/simplify/SimplifiedOpDescriptionGenerator.java b/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/simplify/SimplifiedOpDescriptionGenerator.java
@@ -114,7 +114,12 @@ private Optional<String> getNonOpString(OpEnvironment env, String name) {
 			prefix = "Names:\n\t> ";
 		}
 		if (nsStream == null) return Optional.empty();
-	  return Optional.of(prefix + nsStream.collect(Collectors.joining("\n\t> ")));
+		String suffix = nsStream.collect(Collectors.joining("\n\t> "));
+
+		if (Strings.isNullOrEmpty(suffix))
+			return Optional.of("Not a valid Op name or namespace:\n\t> " + name);
+
+	  return Optional.of(prefix + suffix);
 	}
 
 	/**
diff --git a/scijava-ops-engine/src/test/java/org/scijava/ops/engine/OpEnvironmentTest.java b/scijava-ops-engine/src/test/java/org/scijava/ops/engine/OpEnvironmentTest.java
@@ -83,6 +83,16 @@ public void testHelpVerboseNoNS() {
 		Assertions.assertEquals(expected, descriptions);
 	}
 
+	@Test
+	public void testHelpVerboseInvalid() {
+		OpEnvironment helpEnv = makeHelpEnv("help.verbose1", "help.verbose2");
+
+		// Test that our namespace is found
+		String descriptions = helpEnv.helpVerbose("ichneumon");
+		String expected = "Not a valid Op name or namespace:\n\t> ichneumon";
+		Assertions.assertEquals(expected, descriptions);
+	}
+
 	@Test
 	public void testHelpVerboseNS() {
 		OpEnvironment helpEnv = makeHelpEnv("help.verbose1", "help.verbose2");

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,12 @@ private Optional<String> getNonOpString(OpEnvironment env, String name) {`
`114`	`114`	`prefix = "Names:\n\t> ";`
`115`	`115`	`}`
`116`	`116`	`if (nsStream == null) return Optional.empty();`
`117`		`- return Optional.of(prefix + nsStream.collect(Collectors.joining("\n\t> ")));`
	`117`	`+ String suffix = nsStream.collect(Collectors.joining("\n\t> "));`
	`118`	`+`
	`119`	`+ if (Strings.isNullOrEmpty(suffix))`
	`120`	`+ return Optional.of("Not a valid Op name or namespace:\n\t> " + name);`
	`121`	`+`
	`122`	`+ return Optional.of(prefix + suffix);`
`118`	`123`	`}`
`119`	`124`
`120`	`125`	`/**`