AbstractTestEnvironment: context cannot be static

ctrueden · ctrueden · commit 8bb78c52c5c8 · 2019-06-19T14:43:05.000-05:00
One should be created per test instance.
This is more friendly for multiple threads.
(Although in counterpoint: "mvn -T 8 test" works without this change.)
diff --git a/src/test/java/org/scijava/ops/AbstractTestEnvironment.java b/src/test/java/org/scijava/ops/AbstractTestEnvironment.java
@@ -8,8 +8,8 @@
 
 public abstract class AbstractTestEnvironment {
 
-	private static Context context;
-	private static OpService ops;
+	private Context context;
+	private OpService ops;
 
 	@Before
 	public void setUp() {
@@ -24,7 +24,7 @@ public void tearDown() {
 		ops = null;
 	}
 	
-	public static OpService ops() {
+	public OpService ops() {
 		return ops;
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -8,8 +8,8 @@`
`8`	`8`
`9`	`9`	`public abstract class AbstractTestEnvironment {`
`10`	`10`
`11`		`- private static Context context;`
`12`		`- private static OpService ops;`
	`11`	`+ private Context context;`
	`12`	`+ private OpService ops;`
`13`	`13`
`14`	`14`	`@Before`
`15`	`15`	`public void setUp() {`
`@@ -24,7 +24,7 @@ public void tearDown() {`
`24`	`24`	`ops = null;`
`25`	`25`	`}`
`26`	`26`
`27`		`- public static OpService ops() {`
	`27`	`+ public OpService ops() {`
`28`	`28`	`return ops;`
`29`	`29`	`}`
`30`	`30`